Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1201)

Side by Side Diff: chrome/installer/util/google_chrome_binaries_distribution.h

Issue 10246007: Fix GetAppShortcutName to return a localized name for Chrome (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: string16 madness Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
grt (UTC plus 2) 2012/04/27 18:23:07 2011 -> 2012
gab 2012/04/27 20:58:45 Done.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // This file declares a class that contains various method related to branding. 5 // This file declares a class that contains various method related to branding.
gab 2012/04/27 20:58:45 declares -> defines Done here too.
grt (UTC plus 2) 2012/04/29 02:08:50 please revert this change, as "declares" was corre
gab 2012/04/30 12:37:25 Right, reverted.
6 6
7 #ifndef CHROME_INSTALLER_UTIL_GOOGLE_CHROME_BINARIES_DISTRIBUTION_H_ 7 #ifndef CHROME_INSTALLER_UTIL_GOOGLE_CHROME_BINARIES_DISTRIBUTION_H_
8 #define CHROME_INSTALLER_UTIL_GOOGLE_CHROME_BINARIES_DISTRIBUTION_H_ 8 #define CHROME_INSTALLER_UTIL_GOOGLE_CHROME_BINARIES_DISTRIBUTION_H_
9 #pragma once 9 #pragma once
10 10
11 #include "base/string16.h"
grt (UTC plus 2) 2012/04/27 18:23:07 remove
gab 2012/04/27 20:58:45 Done.
11 #include "chrome/installer/util/chromium_binaries_distribution.h" 12 #include "chrome/installer/util/chromium_binaries_distribution.h"
12 13
13 class GoogleChromeBinariesDistribution : public ChromiumBinariesDistribution { 14 class GoogleChromeBinariesDistribution : public ChromiumBinariesDistribution {
14 public: 15 public:
15 virtual std::wstring GetAppGuid(); 16 virtual string16 GetAppGuid();
16 17
17 virtual std::wstring GetAppShortCutName(); 18 virtual string16 GetAppShortCutName();
18 19
19 virtual std::wstring GetStateKey(); 20 virtual string16 GetStateKey();
20 21
21 virtual std::wstring GetStateMediumKey(); 22 virtual string16 GetStateMediumKey();
22 23
23 virtual std::wstring GetVersionKey(); 24 virtual string16 GetVersionKey();
24 25
25 virtual void UpdateInstallStatus(bool system_install, 26 virtual void UpdateInstallStatus(bool system_install,
26 installer::ArchiveType archive_type, 27 installer::ArchiveType archive_type,
27 installer::InstallStatus install_status); 28 installer::InstallStatus install_status);
28 29
29 protected: 30 protected:
30 friend class BrowserDistribution; 31 friend class BrowserDistribution;
31 32
32 GoogleChromeBinariesDistribution(); 33 GoogleChromeBinariesDistribution();
33 34
34 private: 35 private:
35 DISALLOW_COPY_AND_ASSIGN(GoogleChromeBinariesDistribution); 36 DISALLOW_COPY_AND_ASSIGN(GoogleChromeBinariesDistribution);
36 }; 37 };
37 38
38 #endif // CHROME_INSTALLER_UTIL_GOOGLE_CHROME_BINARIES_DISTRIBUTION_H_ 39 #endif // CHROME_INSTALLER_UTIL_GOOGLE_CHROME_BINARIES_DISTRIBUTION_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698