Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Side by Side Diff: chrome/installer/util/chromium_binaries_distribution.cc

Issue 10246007: Fix GetAppShortcutName to return a localized name for Chrome (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: string16 madness Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
grt (UTC plus 2) 2012/04/27 18:23:07 2011 -> 2012
gab 2012/04/27 20:58:45 Done.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // This file declares a class that contains various method related to branding. 5 // This file declares a class that contains various method related to branding.
6 6
7 #include "chrome/installer/util/google_chrome_binaries_distribution.h" 7 #include "chrome/installer/util/google_chrome_binaries_distribution.h"
8 8
9 #include "base/logging.h" 9 #include "base/logging.h"
10 10
11 namespace { 11 namespace {
12 12
13 const wchar_t kChromiumBinariesName[] = L"Chromium Binaries"; 13 const wchar_t kChromiumBinariesName[] = L"Chromium Binaries";
14 14
15 } // namespace 15 } // namespace
16 16
17 ChromiumBinariesDistribution::ChromiumBinariesDistribution() 17 ChromiumBinariesDistribution::ChromiumBinariesDistribution()
18 : BrowserDistribution(CHROME_BINARIES), 18 : BrowserDistribution(CHROME_BINARIES),
19 browser_distribution_( 19 browser_distribution_(
20 BrowserDistribution::GetSpecificDistribution(CHROME_BROWSER)) { 20 BrowserDistribution::GetSpecificDistribution(CHROME_BROWSER)) {
21 } 21 }
22 22
23 std::wstring ChromiumBinariesDistribution::GetAppGuid() { 23 string16 ChromiumBinariesDistribution::GetAppGuid() {
24 return std::wstring(); 24 return string16();
25 } 25 }
26 26
27 std::wstring ChromiumBinariesDistribution::GetApplicationName() { 27 string16 ChromiumBinariesDistribution::GetApplicationName() {
28 NOTREACHED(); 28 NOTREACHED();
29 return std::wstring(); 29 return string16();
30 } 30 }
31 31
32 std::wstring ChromiumBinariesDistribution::GetAppShortCutName() { 32 string16 ChromiumBinariesDistribution::GetAppShortCutName() {
33 return kChromiumBinariesName; 33 return kChromiumBinariesName;
34 } 34 }
35 35
36 std::wstring ChromiumBinariesDistribution::GetAlternateApplicationName() { 36 string16 ChromiumBinariesDistribution::GetAlternateApplicationName() {
37 NOTREACHED(); 37 NOTREACHED();
38 return std::wstring(); 38 return string16();
39 } 39 }
40 40
41 std::wstring ChromiumBinariesDistribution::GetBrowserAppId() { 41 string16 ChromiumBinariesDistribution::GetBrowserAppId() {
42 NOTREACHED(); 42 NOTREACHED();
43 return std::wstring(); 43 return string16();
44 } 44 }
45 45
46 std::wstring ChromiumBinariesDistribution::GetInstallSubDir() { 46 string16 ChromiumBinariesDistribution::GetInstallSubDir() {
47 return browser_distribution_->GetInstallSubDir(); 47 return browser_distribution_->GetInstallSubDir();
48 } 48 }
49 49
50 std::wstring ChromiumBinariesDistribution::GetPublisherName() { 50 string16 ChromiumBinariesDistribution::GetPublisherName() {
51 NOTREACHED(); 51 NOTREACHED();
52 return std::wstring(); 52 return string16();
53 } 53 }
54 54
55 std::wstring ChromiumBinariesDistribution::GetAppDescription() { 55 string16 ChromiumBinariesDistribution::GetAppDescription() {
56 NOTREACHED(); 56 NOTREACHED();
57 return std::wstring(); 57 return string16();
58 } 58 }
59 59
60 std::wstring ChromiumBinariesDistribution::GetLongAppDescription() { 60 string16 ChromiumBinariesDistribution::GetLongAppDescription() {
61 NOTREACHED(); 61 NOTREACHED();
62 return std::wstring(); 62 return string16();
63 } 63 }
64 64
65 std::string ChromiumBinariesDistribution::GetSafeBrowsingName() { 65 std::string ChromiumBinariesDistribution::GetSafeBrowsingName() {
66 NOTREACHED(); 66 NOTREACHED();
67 return std::string(); 67 return std::string();
68 } 68 }
69 69
70 std::wstring ChromiumBinariesDistribution::GetStateKey() { 70 string16 ChromiumBinariesDistribution::GetStateKey() {
71 return std::wstring(L"Software\\").append(kChromiumBinariesName); 71 return string16(L"Software\\").append(kChromiumBinariesName);
72 } 72 }
73 73
74 std::wstring ChromiumBinariesDistribution::GetStateMediumKey() { 74 string16 ChromiumBinariesDistribution::GetStateMediumKey() {
75 return std::wstring(L"Software\\").append(kChromiumBinariesName); 75 return string16(L"Software\\").append(kChromiumBinariesName);
76 } 76 }
77 77
78 std::wstring ChromiumBinariesDistribution::GetUninstallLinkName() { 78 string16 ChromiumBinariesDistribution::GetUninstallLinkName() {
79 NOTREACHED(); 79 NOTREACHED();
80 return std::wstring(); 80 return string16();
81 } 81 }
82 82
83 std::wstring ChromiumBinariesDistribution::GetUninstallRegPath() { 83 string16 ChromiumBinariesDistribution::GetUninstallRegPath() {
84 NOTREACHED(); 84 NOTREACHED();
85 return std::wstring(); 85 return string16();
86 } 86 }
87 87
88 std::wstring ChromiumBinariesDistribution::GetVersionKey() { 88 string16 ChromiumBinariesDistribution::GetVersionKey() {
89 return std::wstring(L"Software\\").append(kChromiumBinariesName); 89 return string16(L"Software\\").append(kChromiumBinariesName);
90 } 90 }
91 91
92 bool ChromiumBinariesDistribution::CanSetAsDefault() { 92 bool ChromiumBinariesDistribution::CanSetAsDefault() {
93 NOTREACHED(); 93 NOTREACHED();
94 return false; 94 return false;
95 } 95 }
96 96
97 int ChromiumBinariesDistribution::GetIconIndex() { 97 int ChromiumBinariesDistribution::GetIconIndex() {
98 NOTREACHED(); 98 NOTREACHED();
99 return 0; 99 return 0;
100 } 100 }
101 101
102 bool ChromiumBinariesDistribution::GetChromeChannel(std::wstring* channel) { 102 bool ChromiumBinariesDistribution::GetChromeChannel(string16* channel) {
103 NOTREACHED(); 103 NOTREACHED();
104 return false; 104 return false;
105 } 105 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698