Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Side by Side Diff: chrome/installer/util/chrome_frame_distribution.h

Issue 10246007: Fix GetAppShortcutName to return a localized name for Chrome (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: string16 madness Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // This file extends the browser distribution with a specific implementation 5 // This file extends the browser distribution with a specific implementation
6 // for Chrome Frame. 6 // for Chrome Frame.
7 7
8 #ifndef CHROME_INSTALLER_UTIL_CHROME_FRAME_DISTRIBUTION_H_ 8 #ifndef CHROME_INSTALLER_UTIL_CHROME_FRAME_DISTRIBUTION_H_
9 #define CHROME_INSTALLER_UTIL_CHROME_FRAME_DISTRIBUTION_H_ 9 #define CHROME_INSTALLER_UTIL_CHROME_FRAME_DISTRIBUTION_H_
10 #pragma once 10 #pragma once
11 11
12 #include <string> 12 #include <string>
grt (UTC plus 2) 2012/04/27 18:23:07 remove this since the only uses of std::string are
gab 2012/04/27 20:58:45 Done.
13 #include <vector> 13 #include <vector>
grt (UTC plus 2) 2012/04/27 18:23:07 this seems stale. please remove while you're here
gab 2012/04/27 20:58:45 Done.
14 14
15 #include "base/string16.h"
grt (UTC plus 2) 2012/04/27 18:23:07 remove this for same reason as <string>
gab 2012/04/27 20:58:45 Done.
15 #include "chrome/installer/util/browser_distribution.h" 16 #include "chrome/installer/util/browser_distribution.h"
16 #include "chrome/installer/util/util_constants.h" 17 #include "chrome/installer/util/util_constants.h"
17 18
18 class ChromeFrameDistribution : public BrowserDistribution { 19 class ChromeFrameDistribution : public BrowserDistribution {
19 public: 20 public:
20 virtual std::wstring GetAppGuid() OVERRIDE; 21 virtual string16 GetAppGuid() OVERRIDE;
21 22
22 virtual std::wstring GetApplicationName() OVERRIDE; 23 virtual string16 GetApplicationName() OVERRIDE;
23 24
24 virtual std::wstring GetAppShortCutName() OVERRIDE; 25 virtual string16 GetAppShortCutName() OVERRIDE;
25 26
26 virtual std::wstring GetAlternateApplicationName() OVERRIDE; 27 virtual string16 GetAlternateApplicationName() OVERRIDE;
27 28
28 virtual std::wstring GetInstallSubDir() OVERRIDE; 29 virtual string16 GetInstallSubDir() OVERRIDE;
29 30
30 virtual std::wstring GetPublisherName() OVERRIDE; 31 virtual string16 GetPublisherName() OVERRIDE;
31 32
32 virtual std::wstring GetAppDescription() OVERRIDE; 33 virtual string16 GetAppDescription() OVERRIDE;
33 34
34 virtual std::wstring GetLongAppDescription() OVERRIDE; 35 virtual string16 GetLongAppDescription() OVERRIDE;
35 36
36 virtual std::string GetSafeBrowsingName() OVERRIDE; 37 virtual std::string GetSafeBrowsingName() OVERRIDE;
37 38
38 virtual std::wstring GetStateKey() OVERRIDE; 39 virtual string16 GetStateKey() OVERRIDE;
39 40
40 virtual std::wstring GetStateMediumKey() OVERRIDE; 41 virtual string16 GetStateMediumKey() OVERRIDE;
41 42
42 virtual std::wstring GetStatsServerURL() OVERRIDE; 43 virtual string16 GetStatsServerURL() OVERRIDE;
43 44
44 virtual std::string GetNetworkStatsServer() const OVERRIDE; 45 virtual std::string GetNetworkStatsServer() const OVERRIDE;
45 46
46 virtual std::string GetHttpPipeliningTestServer() const OVERRIDE; 47 virtual std::string GetHttpPipeliningTestServer() const OVERRIDE;
47 48
48 virtual std::wstring GetUninstallLinkName() OVERRIDE; 49 virtual string16 GetUninstallLinkName() OVERRIDE;
49 50
50 virtual std::wstring GetUninstallRegPath() OVERRIDE; 51 virtual string16 GetUninstallRegPath() OVERRIDE;
51 52
52 virtual std::wstring GetVersionKey() OVERRIDE; 53 virtual string16 GetVersionKey() OVERRIDE;
53 54
54 virtual bool CanSetAsDefault() OVERRIDE; 55 virtual bool CanSetAsDefault() OVERRIDE;
55 56
56 virtual bool CanCreateDesktopShortcuts() OVERRIDE; 57 virtual bool CanCreateDesktopShortcuts() OVERRIDE;
57 58
58 virtual bool GetDelegateExecuteHandlerData(string16* handler_class_uuid, 59 virtual bool GetDelegateExecuteHandlerData(string16* handler_class_uuid,
59 string16* type_lib_uuid, 60 string16* type_lib_uuid,
60 string16* type_lib_version, 61 string16* type_lib_version,
61 string16* interface_uuid) OVERRIDE; 62 string16* interface_uuid) OVERRIDE;
62 63
63 virtual void UpdateInstallStatus(bool system_install, 64 virtual void UpdateInstallStatus(bool system_install,
64 installer::ArchiveType archive_type, 65 installer::ArchiveType archive_type,
65 installer::InstallStatus install_status) OVERRIDE; 66 installer::InstallStatus install_status) OVERRIDE;
66 67
67 protected: 68 protected:
68 friend class BrowserDistribution; 69 friend class BrowserDistribution;
69 70
70 // Disallow construction from non-friends. 71 // Disallow construction from non-friends.
71 ChromeFrameDistribution(); 72 ChromeFrameDistribution();
72 }; 73 };
73 74
74 #endif // CHROME_INSTALLER_UTIL_CHROME_FRAME_DISTRIBUTION_H_ 75 #endif // CHROME_INSTALLER_UTIL_CHROME_FRAME_DISTRIBUTION_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698