Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Unified Diff: chrome/browser/web_applications/web_app_mac.mm

Issue 10245003: Makes ImageSkia more like SkBitmap (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Updated comment Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/themes/browser_theme_pack.cc ('k') | skia/ext/skia_utils_mac.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/web_applications/web_app_mac.mm
diff --git a/chrome/browser/web_applications/web_app_mac.mm b/chrome/browser/web_applications/web_app_mac.mm
index bcc7991e1a58ca84d51bb5334f0560cee095a6cb..46ce5f5c13fb0f4f203001dbc8d33860839394c1 100644
--- a/chrome/browser/web_applications/web_app_mac.mm
+++ b/chrome/browser/web_applications/web_app_mac.mm
@@ -198,10 +198,9 @@ bool WebAppShortcutCreator::UpdateIcon(const FilePath& app_path) const {
scoped_nsobject<IconFamily> icon_family([[IconFamily alloc] init]);
bool image_added = false;
- const std::vector<const SkBitmap*>& bitmaps =
- info_.favicon.ToImageSkia()->bitmaps();
+ const std::vector<SkBitmap> bitmaps = info_.favicon.ToImageSkia()->bitmaps();
for (size_t i = 0; i < bitmaps.size(); ++i) {
- NSBitmapImageRep* image_rep = SkBitmapToImageRep(*bitmaps[i]);
+ NSBitmapImageRep* image_rep = SkBitmapToImageRep(bitmaps[i]);
if (!image_rep)
continue;
« no previous file with comments | « chrome/browser/themes/browser_theme_pack.cc ('k') | skia/ext/skia_utils_mac.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698