Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5144)

Unified Diff: chrome/browser/extensions/image_loading_tracker.cc

Issue 10245003: Makes ImageSkia more like SkBitmap (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Updated comment Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/image_loading_tracker_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/image_loading_tracker.cc
diff --git a/chrome/browser/extensions/image_loading_tracker.cc b/chrome/browser/extensions/image_loading_tracker.cc
index 3bbf4334e5f92bb97ba9281c7123ec73530a5f8e..ab43b062a0980078317b17fa7d74080e54ec2476 100644
--- a/chrome/browser/extensions/image_loading_tracker.cc
+++ b/chrome/browser/extensions/image_loading_tracker.cc
@@ -18,6 +18,7 @@
#include "skia/ext/image_operations.h"
#include "third_party/skia/include/core/SkBitmap.h"
#include "ui/gfx/image/image.h"
+#include "ui/gfx/image/image_skia.h"
#include "webkit/glue/image_decoder.h"
using content::BrowserThread;
@@ -303,13 +304,13 @@ void ImageLoadingTracker::OnImageLoaded(
std::string extension_id = info->extension_id;
if (info->bitmaps.size() > 0) {
- std::vector<const SkBitmap*> bitmaps;
+ gfx::ImageSkia image_skia;
for (std::vector<SkBitmap>::const_iterator it = info->bitmaps.begin();
it != info->bitmaps.end(); ++it) {
- // gfx::Image takes ownership of this bitmap.
- bitmaps.push_back(new SkBitmap(*it));
+ // TODO(pkotwicz): Do something better but ONLY when ENABLE_DIP.
+ image_skia.AddBitmapForScale(*it, 1.0f);
}
- image = gfx::Image(bitmaps);
+ image = gfx::Image(image_skia);
}
load_map_.erase(load_map_it);
« no previous file with comments | « no previous file | chrome/browser/extensions/image_loading_tracker_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698