Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1521)

Unified Diff: chrome/browser/resources/bookmark_manager/js/bookmark_all_tabs.js

Issue 10244005: convert bookmark manager to loadTimeData from localStrings (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/bookmark_manager/js/bookmark_all_tabs.js
diff --git a/chrome/browser/resources/bookmark_manager/js/bookmark_all_tabs.js b/chrome/browser/resources/bookmark_manager/js/bookmark_all_tabs.js
index f264ed68b1022c4f53d44851a86c21f643a56c84..6735f4f9b7a74593ee03fb95fc8f6df86bf4a4c8 100644
--- a/chrome/browser/resources/bookmark_manager/js/bookmark_all_tabs.js
+++ b/chrome/browser/resources/bookmark_manager/js/bookmark_all_tabs.js
@@ -14,12 +14,6 @@ const NEWFOLDER_SELECTION_DELAY = 50;
if (!chrome.bookmarks)
console.error('Bookmarks extension API is not available');
-/**
- * The local strings object which is used to do the translation.
- * @type {!LocalStrings}
- */
-var localStrings = new LocalStrings;
-
// Get the localized strings from the backend.
chrome.experimental.bookmarkManager.getStrings(function(data) {
// The strings may contain & which we need to strip.
@@ -27,8 +21,10 @@ chrome.experimental.bookmarkManager.getStrings(function(data) {
data[key] = data[key].replace(/&/, '');
}
- localStrings.templateData = data;
- i18nTemplate.process(document, data);
+ loadTimeData.data = data;
+ var process = document.createElement('script');
+ process.src = "chrome://resources/js/i18n_template2.js";
Dan Beam 2012/04/30 17:04:00 single quotes
Evan Stade 2012/04/30 18:41:48 I confirmed with the author this file is no longer
+ document.body.appendChild(process);
});
/**
@@ -121,7 +117,7 @@ checkDisabilities();
function newFolder() {
var parentId = tree.selectedItem.bookmarkId;
chrome.bookmarks.create({
- title: localStrings.getString('new_folder_name'),
+ title: loadTimeData.getString('new_folder_name'),
parentId: parentId
}, function(newNode) {
// This callback happens before the event that triggers the tree/list to

Powered by Google App Engine
This is Rietveld 408576698