Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(881)

Unified Diff: chrome/browser/resources/bookmark_manager/js/bmm/bookmark_list.js

Issue 10244005: convert bookmark manager to loadTimeData from localStrings (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/bookmark_manager/js/bmm/bookmark_list.js
diff --git a/chrome/browser/resources/bookmark_manager/js/bmm/bookmark_list.js b/chrome/browser/resources/bookmark_manager/js/bmm/bookmark_list.js
index b065b4bceb6d8dec888ef788f57e98b09b29347c..c598feb88df8052b242b0602d568ce4a4c2715f0 100644
--- a/chrome/browser/resources/bookmark_manager/js/bmm/bookmark_list.js
+++ b/chrome/browser/resources/bookmark_manager/js/bmm/bookmark_list.js
@@ -469,7 +469,7 @@ cr.define('bmm', function() {
labelInput = doc.createElement('input');
labelInput.placeholder =
- localStrings.getString('name_input_placeholder');
+ loadTimeData.getString('name_input_placeholder');
replaceAllChildren(labelEl, labelInput);
labelInput.value = title;
@@ -478,7 +478,7 @@ cr.define('bmm', function() {
urlInput.type = 'url';
urlInput.required = true;
urlInput.placeholder =
- localStrings.getString('url_input_placeholder');
+ loadTimeData.getString('url_input_placeholder');
// We also need a name for the input for the CSS to work.
urlInput.name = '-url-input-' + cr.createUid();
@@ -539,7 +539,7 @@ cr.define('bmm', function() {
var sm = this.parentNode.selectionModel;
sm.selectedIndex = sm.leadIndex = sm.anchorIndex = index;
- alert(localStrings.getString('invalid_url'));
+ alert(loadTimeData.getString('invalid_url'));
Dan Beam 2012/04/30 17:04:00 every time an alert() box pops up a baby seal crie
}
urlInput.focus();
urlInput.select();

Powered by Google App Engine
This is Rietveld 408576698