convert bookmark manager to loadTimeData from localStrings

chrome/browser/resources/bookmark_manager/js/main.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 const BookmarkList = bmm.BookmarkList;
 const BookmarkTree = bmm.BookmarkTree;
 const ListItem = cr.ui.ListItem;
 const TreeItem = cr.ui.TreeItem;
 const LinkKind = cr.LinkKind;
 const Command = cr.ui.Command;
 const CommandBinding = cr.ui.CommandBinding;
 const Menu = cr.ui.Menu;
 const MenuButton  = cr.ui.MenuButton;
 const Promise = cr.Promise;
 
 // Sometimes the extension API is not initialized.
 if (!chrome.bookmarks)
   console.error('Bookmarks extension API is not available');
 
-/**
- * The local strings object which is used to do the translation.
- * @type {!LocalStrings}
- */
-var localStrings = new LocalStrings;
-
 // Get the localized strings from the backend.
 chrome.experimental.bookmarkManager.getStrings(function(data) {
   // The strings may contain & which we need to strip.
   for (var key in data) {
     data[key] = data[key].replace(/&/, '');
   }
 
-  localStrings.templateData = data;
-  i18nTemplate.process(document, data);
+  loadTimeData.data = data;
+  var process = document.createElement('script');
+  process.src = 'chrome://resources/js/i18n_template2.js';

[arv (Not doing code reviews), 2012/05/03 02:13:40]

I don't like. Why is this done in this way?

[Dan Beam, 2012/05/03 03:33:55]

I assumed because we're only setting the loadTimeData here rather than earlier
like in other scripts, so trying to process without any keys would result in
many errors.  Why we don't have the loadTimeData earlier is a different
question, though.

[Evan Stade, 2012/05/03 21:14:44]

yes. i18n_template2.js automatically processes.
because it has to be in this callback?

+  document.body.appendChild(process);
 
-  recentTreeItem.label = localStrings.getString('recent');
-  searchTreeItem.label = localStrings.getString('search');
+  recentTreeItem.label = loadTimeData.getString('recent');
+  searchTreeItem.label = loadTimeData.getString('search');
   if (!isRTL())
     searchTreeItem.icon = 'images/bookmark_manager_search.png'
   else
     searchTreeItem.icon = 'images/bookmark_manager_search_rtl.png'
 });
 
 /**
  * The id of the bookmark root.
  * @type {number}
  */
@@ skipping 820 matching lines @@
     for (var i = 0; i < node.children.length; i++) {
       if (!bmm.isFolder(node.children[i]))
         return true;
     }
     return false;
   }
 
   var commandDisabled = false;
   switch (command.id) {
     case 'open-in-new-tab-command':
-      command.label = localStrings.getString(multiple ?
+      command.label = loadTimeData.getString(multiple ?
           'open_all' : 'open_in_new_tab');
       break;
 
     case 'open-in-new-window-command':
-      command.label = localStrings.getString(multiple ?
+      command.label = loadTimeData.getString(multiple ?
           'open_all_new_window' : 'open_in_new_window');
       // Disabled when incognito is forced.
       commandDisabled = incognitoModeAvailability == 'forced';
       break;
     case 'open-incognito-window-command':
-      command.label = localStrings.getString(multiple ?
+      command.label = loadTimeData.getString(multiple ?
           'open_all_incognito' : 'open_incognito');
       // Not available withn incognito is disabled.
       commandDisabled = incognitoModeAvailability == 'disabled';
       break;
   }
   e.canExecute = selectionCount > 0 && !!selectedItem && !commandDisabled;
   if (isFolder && e.canExecute) {
     // We need to get all the bookmark items in this tree. If the tree does not
     // contain any non-folders, we need to disable the command.
     var p = bmm.loadSubtree(selectedItem.id);
@@ skipping 326 matching lines @@
 }
 
 var linkController;
 
 /**
  * @return {!cr.LinkController} The link controller used to open links based on
  *     user clicks and keyboard actions.
  */
 function getLinkController() {
   return linkController ||
-      (linkController = new cr.LinkController(localStrings));
+      (linkController = new cr.LinkController(loadTimeData));
 }
 
 /**
  * Returns the selected bookmark nodes of the active element. Only call this
  * if the list or the tree is focused.
  * @return {!Array} Array of bookmark nodes.
  */
 function getSelectedBookmarkNodes() {
   if (document.activeElement == list) {
     return list.selectedItems;
@@ skipping 82 matching lines @@
 }
 
 /**
  * Callback for the new folder command. This creates a new folder and starts
  * a rename of it.
  */
 function newFolder() {
   var parentId = list.parentId;
   var isTree = document.activeElement == tree;
   chrome.bookmarks.create({
-    title: localStrings.getString('new_folder_name'),
+    title: loadTimeData.getString('new_folder_name'),
     parentId: parentId
   }, function(newNode) {
     // This callback happens before the event that triggers the tree/list to
     // get updated so delay the work so that the tree/list gets updated first.
     setTimeout(function() {
       var newItem;
       if (isTree) {
         newItem = bmm.treeLookup[newNode.id];
         tree.selectedItem = newItem;
         newItem.editing = true;
@@ skipping 194 matching lines @@
   document.addEventListener('copy', handle('copy-command'));
   document.addEventListener('cut', handle('cut-command'));
 
   var pasteHandler = handle('paste-command');
   document.addEventListener('paste', function(e) {
     // Paste is a bit special since we need to do an async call to see if we can
     // paste because the paste command might not be up to date.
     updatePasteCommand(pasteHandler);
   });
 })();