convert bookmark manager to loadTimeData from localStrings

chrome/browser/resources/bookmark_manager/js/main.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /** @const */ var BookmarkList = bmm.BookmarkList;
 /** @const */ var BookmarkTree = bmm.BookmarkTree;
 /** @const */ var Command = cr.ui.Command;
 /** @const */ var CommandBinding = cr.ui.CommandBinding;
 /** @const */ var LinkKind = cr.LinkKind;
 /** @const */ var ListItem = cr.ui.ListItem;
 /** @const */ var Menu = cr.ui.Menu;
 /** @const */ var MenuButton  = cr.ui.MenuButton;
 /** @const */ var Promise = cr.Promise;
 /** @const */ var Splitter = cr.ui.Splitter;
 /** @const */ var TreeItem = cr.ui.TreeItem;
 
 // Sometimes the extension API is not initialized.
 if (!chrome.bookmarks)
   console.error('Bookmarks extension API is not available');
 
-/**
- * The local strings object which is used to do the translation.
- * @type {!LocalStrings}
- */
-var localStrings = new LocalStrings;
-
 // Get the localized strings from the backend.
 chrome.experimental.bookmarkManager.getStrings(function(data) {
   // The strings may contain & which we need to strip.
   for (var key in data) {
     data[key] = data[key].replace(/&/, '');
   }
 
-  localStrings.templateData = data;
-  i18nTemplate.process(document, data);
+  loadTimeData.data = data;
+  i18nTemplate.process(document, loadTimeData);
 
-  recentTreeItem.label = localStrings.getString('recent');
-  searchTreeItem.label = localStrings.getString('search');
+  recentTreeItem.label = loadTimeData.getString('recent');
+  searchTreeItem.label = loadTimeData.getString('search');
   if (!isRTL())
     searchTreeItem.icon = 'images/bookmark_manager_search.png'
   else
     searchTreeItem.icon = 'images/bookmark_manager_search_rtl.png'
 });
 
 /**
  * The id of the bookmark root.
  * @type {number}
  */
@@ skipping 833 matching lines @@
     for (var i = 0; i < node.children.length; i++) {
       if (!bmm.isFolder(node.children[i]))
         return true;
     }
     return false;
   }
 
   var commandDisabled = false;
   switch (command.id) {
     case 'open-in-new-tab-command':
-      command.label = localStrings.getString(multiple ?
+      command.label = loadTimeData.getString(multiple ?
           'open_all' : 'open_in_new_tab');
       break;
 
     case 'open-in-new-window-command':
-      command.label = localStrings.getString(multiple ?
+      command.label = loadTimeData.getString(multiple ?
           'open_all_new_window' : 'open_in_new_window');
       // Disabled when incognito is forced.
       commandDisabled = incognitoModeAvailability == 'forced';
       break;
     case 'open-incognito-window-command':
-      command.label = localStrings.getString(multiple ?
+      command.label = loadTimeData.getString(multiple ?
           'open_all_incognito' : 'open_incognito');
       // Not available withn incognito is disabled.
       commandDisabled = incognitoModeAvailability == 'disabled';
       break;
   }
   e.canExecute = selectionCount > 0 && !!selectedItem && !commandDisabled;
   if (isFolder && e.canExecute) {
     // We need to get all the bookmark items in this tree. If the tree does not
     // contain any non-folders, we need to disable the command.
     var p = bmm.loadSubtree(selectedItem.id);
@@ skipping 342 matching lines @@
 }
 
 var linkController;
 
 /**
  * @return {!cr.LinkController} The link controller used to open links based on
  *     user clicks and keyboard actions.
  */
 function getLinkController() {
   return linkController ||
-      (linkController = new cr.LinkController(localStrings));
+      (linkController = new cr.LinkController(loadTimeData));

[Dan Beam, 2012/05/08 22:34:25]

nit: I think this could be less succinct but more readable.

[Evan Stade, 2012/05/08 23:32:13]

I was not the author, and I have no trouble reading it.

[Dan Beam, 2012/05/08 23:46:51]

I think it'd be more readable as:

  if (!linkController)
    linkController = new cr.LinkController(loadTimeData);

  return linkController;

We don't prefer this in C++ (we have to explicitly say if ((a = getNext())) {}),
so I don't know why we'd do it in JS.

[Evan Stade, 2012/05/09 23:16:54]

actually, it's not a matter of preference in C++, it simply doesn't work.
Luckily this is not C++.

 }
 
 /**
  * Returns the selected bookmark nodes of the active element. Only call this
  * if the list or the tree is focused.
  * @return {!Array} Array of bookmark nodes.
  */
 function getSelectedBookmarkNodes() {
   if (document.activeElement == list) {
     return list.selectedItems;
@@ skipping 144 matching lines @@
 }
 
 /**
  * Callback for the new folder command. This creates a new folder and starts
  * a rename of it.
  */
 function newFolder() {
   var parentId = list.parentId;
   var isTree = document.activeElement == tree;
   chrome.bookmarks.create({
-    title: localStrings.getString('new_folder_name'),
+    title: loadTimeData.getString('new_folder_name'),
     parentId: parentId
   }, function(newNode) {
     // This callback happens before the event that triggers the tree/list to
     // get updated so delay the work so that the tree/list gets updated first.
     setTimeout(function() {
       var newItem;
       if (isTree) {
         newItem = bmm.treeLookup[newNode.id];
         tree.selectedItem = newItem;
         newItem.editing = true;
@@ skipping 201 matching lines @@
   document.addEventListener('copy', handle('copy-command'));
   document.addEventListener('cut', handle('cut-command'));
 
   var pasteHandler = handle('paste-command');
   document.addEventListener('paste', function(e) {
     // Paste is a bit special since we need to do an async call to see if we can
     // paste because the paste command might not be up to date.
     updatePasteCommand(pasteHandler);
   });
 })();