convert bookmark manager to loadTimeData from localStrings

chrome/browser/resources/bookmark_manager/js/bookmark_all_tabs.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 const BookmarkTree = bmm.BookmarkTree;
 const TreeItem = cr.ui.TreeItem;
 
 // Delay time (ms) of updating hash after changing current folder.
 const NAVIGATE_HASH_UPDATE_DELAY = 250;
 // Delay time (ms) of selecting new folder after creation of it.
 const NEWFOLDER_SELECTION_DELAY = 50;
 
 // Sometimes the extension API is not initialized.
 if (!chrome.bookmarks)
   console.error('Bookmarks extension API is not available');
 
-/**
- * The local strings object which is used to do the translation.
- * @type {!LocalStrings}
- */
-var localStrings = new LocalStrings;
-
 // Get the localized strings from the backend.
 chrome.experimental.bookmarkManager.getStrings(function(data) {
   // The strings may contain & which we need to strip.
   for (var key in data) {
     data[key] = data[key].replace(/&/, '');
   }
 
-  localStrings.templateData = data;
-  i18nTemplate.process(document, data);
+  loadTimeData.data = data;
+  var process = document.createElement('script');
+  process.src = "chrome://resources/js/i18n_template2.js";

[Dan Beam, 2012/04/30 17:04:00]

single quotes

[Evan Stade, 2012/04/30 18:41:48]

I confirmed with the author this file is no longer used, so I've reverted my
changes to it and later I'll just remove the file as a whole.

I did make the single quote change in main.js

+  document.body.appendChild(process);
 });
 
 /**
  * The id of the bookmark root.
  * @type {number}
  */
 const ROOT_ID = '0';

[Dan Beam, 2012/04/30 17:04:00]

you're gonna get a warning about using const here, btw

[Evan Stade, 2012/04/30 18:41:48]

oh, just touching this file produces a lot of warnings, which I happily ignore.

 
 var searchTreeItem = new TreeItem({
   icon: 'images/bookmark_manager_search.png',
   bookmarkId: 'q='
 });
 bmm.treeLookup[searchTreeItem.bookmarkId] = searchTreeItem;
 
 var recentTreeItem = new TreeItem({
   icon: 'images/bookmark_manager_recent.png',
   bookmarkId: 'recent'
@@ skipping 65 matching lines @@
 tree.addEventListener('change', checkDisabilities);
 checkDisabilities();
 
 /**
  * Callback for the new folder command. This creates a new folder and starts
  * a rename of it.
  */
 function newFolder() {
   var parentId = tree.selectedItem.bookmarkId;
   chrome.bookmarks.create({
-    title: localStrings.getString('new_folder_name'),
+    title: loadTimeData.getString('new_folder_name'),
     parentId: parentId
   }, function(newNode) {
     // This callback happens before the event that triggers the tree/list to
     // get updated so delay the work so that the tree/list gets updated first.
     setTimeout(function() {
       var newItem = bmm.treeLookup[newNode.id];
       tree.selectedItem = newItem;
       newItem.editing = true;
     }, NEWFOLDER_SELECTION_DELAY);
   });
@@ skipping 55 matching lines @@
     window.close();
   });
 }
 
 /**
  * Adds handlers to buttons.
  */
 document.querySelector('#new-folder').addEventListener('click', newFolder);
 document.querySelector('#save').addEventListener('click', bookmarkAllTabs);
 document.querySelector('#cancel').addEventListener('click', cancel);