Hide "Inspect Element" context menu item from <webview> when <webview>

Hide "Inspect Element" context menu item from <webview> when <webview>
    is embedded in WebUI.
This is no-op in CANARY or tott build.

BUG=469237
Test=launch chrome with --enable-inline-signin
Navigate a tab to sign in page: i.e. chrome://chrome-signin/
Right click on white background, you shouldn't see inpsect element.

Committed: https://crrev.com/78437f79d5bfe182acdbf655a1b3ca08e593e5a3
Cr-Commit-Position: refs/heads/master@{#322040}

[lazyboy, 2015-03-20 19:23:30]

lazyboy@chromium.org changed reviewers:
+ fsamuel@chromium.org

[Fady Samuel, 2015-03-20 19:34:22]

https://chromiumcodereview.appspot.com/1024153002/diff/20001/chrome/browser/g...
File chrome/browser/guest_view/web_view/context_menu_content_type_web_view.cc
(right):

https://chromiumcodereview.appspot.com/1024153002/diff/20001/chrome/browser/g...
chrome/browser/guest_view/web_view/context_menu_content_type_web_view.cc:40:
chrome::VersionInfo::CHANNEL_CANARY) {
This code doesn't make sense to me.

if (chrome::VersionInfo::GetChannel() <=
    chrome::VersionInfo::CHANNEL_CANARY) {
  return true;
}

...

[lazyboy, 2015-03-20 19:49:20]

Patchset #3 (id:40001) has been deleted

[lazyboy, 2015-03-20 19:50:02]

https://chromiumcodereview.appspot.com/1024153002/diff/20001/chrome/browser/g...
File chrome/browser/guest_view/web_view/context_menu_content_type_web_view.cc
(right):

https://chromiumcodereview.appspot.com/1024153002/diff/20001/chrome/browser/g...
chrome/browser/guest_view/web_view/context_menu_content_type_web_view.cc:40:
chrome::VersionInfo::CHANNEL_CANARY) {
On 2015/03/20 19:34:22, Fady Samuel wrote:
> This code doesn't make sense to me.
> 
> if (chrome::VersionInfo::GetChannel() <=
>     chrome::VersionInfo::CHANNEL_CANARY) {
>   return true;
> }
> 
> ...

Grrr, I did the reverse of what I wanted.
Fixed.

[Fady Samuel, 2015-03-20 19:51:54]

lgtm + nits

https://chromiumcodereview.appspot.com/1024153002/diff/60001/chrome/browser/g...
File chrome/browser/guest_view/web_view/context_menu_content_type_web_view.cc
(right):

https://chromiumcodereview.appspot.com/1024153002/diff/60001/chrome/browser/g...
chrome/browser/guest_view/web_view/context_menu_content_type_web_view.cc:43:
const extensions::WebViewGuest* web_view_guest =
nit auto might allow you to fit this on one line?

https://chromiumcodereview.appspot.com/1024153002/diff/60001/chrome/browser/g...
chrome/browser/guest_view/web_view/context_menu_content_type_web_view.cc:45: if
(web_view_guest && web_view_guest->embedder_web_contents()) {
Just use owner_web_contents which is always non-nullptr. That saves you a
condition to check.

[lazyboy, 2015-03-20 20:00:29]

https://chromiumcodereview.appspot.com/1024153002/diff/60001/chrome/browser/g...
File chrome/browser/guest_view/web_view/context_menu_content_type_web_view.cc
(right):

https://chromiumcodereview.appspot.com/1024153002/diff/60001/chrome/browser/g...
chrome/browser/guest_view/web_view/context_menu_content_type_web_view.cc:43:
const extensions::WebViewGuest* web_view_guest =
On 2015/03/20 19:51:54, Fady Samuel wrote:
> nit auto might allow you to fit this on one line?

Doesn't fit in one line, but auto makes things readable anyway.

https://chromiumcodereview.appspot.com/1024153002/diff/60001/chrome/browser/g...
chrome/browser/guest_view/web_view/context_menu_content_type_web_view.cc:45: if
(web_view_guest && web_view_guest->embedder_web_contents()) {
On 2015/03/20 19:51:54, Fady Samuel wrote:
> Just use owner_web_contents which is always non-nullptr. That saves you a
> condition to check.

Done.

[lazyboy, 2015-03-20 20:10:26]

+Jochen for
components/renderer_context_menu/context_menu_content_type.h

[lazyboy, 2015-03-20 20:10:36]

lazyboy@chromium.org changed reviewers:
+ jochen@chromium.org

[lazyboy, 2015-03-20 20:10:37]

+Jochen for
components/renderer_context_menu/context_menu_content_type.h

[jochen (gone - plz use gerrit), 2015-03-24 08:58:54]

lgtm

[lazyboy, 2015-03-24 15:56:27]

The CQ bit was checked by lazyboy@chromium.org

[lazyboy, 2015-03-24 15:56:27]

The patchset sent to the CQ was uploaded after l-g-t-m from fsamuel@chromium.org
Link to the patchset:
https://chromiumcodereview.appspot.com/1024153002/#ps120001 (title: "make
source_web_contents() return const WebContents*")

[commit-bot: I haz the power, 2015-03-24 15:57:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1024153002/120001

[commit-bot: I haz the power, 2015-03-24 16:35:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-24 16:35:37]

Try jobs failed on following builders:
  win8_chromium_rel on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)

[lazyboy, 2015-03-24 18:55:38]

The CQ bit was checked by lazyboy@chromium.org

[lazyboy, 2015-03-24 18:55:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
fsamuel@chromium.org, jochen@chromium.org
Link to the patchset:
https://chromiumcodereview.appspot.com/1024153002/#ps140001 (title: "fix win8
unrechable code")

[commit-bot: I haz the power, 2015-03-24 18:56:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1024153002/140001

[commit-bot: I haz the power, 2015-03-24 19:07:02]

Committed patchset #7 (id:140001)

[commit-bot: I haz the power, 2015-03-24 19:08:17]

Patchset 7 (id:??) landed as
https://crrev.com/78437f79d5bfe182acdbf655a1b3ca08e593e5a3
Cr-Commit-Position: refs/heads/master@{#322040}