Linux: Use the same safe downloads logic as Windows.

Linux: Use the same safe downloads logic as Windows.

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134362

[Lei Zhang, 2012-04-26 22:05:49]

https://chromiumcodereview.appspot.com/10241007/diff/11001/chrome/browser/dow...
File chrome/browser/download/download_util.cc (left):

https://chromiumcodereview.appspot.com/10241007/diff/11001/chrome/browser/dow...
chrome/browser/download/download_util.cc:27: #include
"base/win/windows_version.h"
I don't know how this even compiled. :)

https://chromiumcodereview.appspot.com/10241007/diff/11001/chrome/browser/dow...
chrome/browser/download/download_util.cc:78: static const double PI =
3.141592653589793;
phajdan.jr: M_PI and friends are in cmath / math.h

[Randy Smith (Not in Mondays), 2012-04-26 22:07:48]

Lateralling to ASanka, who I think is in a better position to review this than
I.  Asanka, pull me back in if you think that's the right thing.

[asanka, 2012-04-27 15:53:45]

LGTM.

https://chromiumcodereview.appspot.com/10241007/diff/11001/chrome/browser/dow...
File chrome/browser/download/download_util.cc (right):

https://chromiumcodereview.appspot.com/10241007/diff/11001/chrome/browser/dow...
chrome/browser/download/download_util.cc:104: // Get the opacity based on
|animation_progress|.
Nit: mention |animation_progress| is in [0.0,1.0]

[Lei Zhang, 2012-04-27 18:59:47]

https://chromiumcodereview.appspot.com/10241007/diff/11001/chrome/browser/dow...
File chrome/browser/download/download_util.cc (right):

https://chromiumcodereview.appspot.com/10241007/diff/11001/chrome/browser/dow...
chrome/browser/download/download_util.cc:104: // Get the opacity based on
|animation_progress|.
On 2012/04/27 15:53:45, asanka wrote:
> Nit: mention |animation_progress| is in [0.0,1.0]

Done.

[commit-bot: I haz the power, 2012-04-27 19:00:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thestig@chromium.org/10241007/14001

[asanka, 2012-04-27 19:06:00]

http://codereview.chromium.org/10241007/diff/14001/chrome/browser/download/do...
File chrome/browser/download/download_util.cc (right):

http://codereview.chromium.org/10241007/diff/14001/chrome/browser/download/do...
chrome/browser/download/download_util.cc:107: DCHECK(animation_progress >= 0 &&
animation <= 1);
* animation_progress <= 1

[commit-bot: I haz the power, 2012-04-27 19:26:37]

Try job failure for 10241007-14001 (retry) on linux_clang for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clan...

[Lei Zhang, 2012-04-27 19:50:15]

https://chromiumcodereview.appspot.com/10241007/diff/14001/chrome/browser/dow...
File chrome/browser/download/download_util.cc (right):

https://chromiumcodereview.appspot.com/10241007/diff/14001/chrome/browser/dow...
chrome/browser/download/download_util.cc:107: DCHECK(animation_progress >= 0 &&
animation <= 1);
On 2012/04/27 19:06:00, asanka wrote:
> * animation_progress <= 1

Autocomplete has failed me.

[commit-bot: I haz the power, 2012-04-27 19:53:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thestig@chromium.org/10241007/26001

[commit-bot: I haz the power, 2012-04-27 21:48:37]

Change committed as 134362