Issue 10241002: Fix spurious bugs in GrowAndShrinkNewSpace when the

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10241002: Fix spurious bugs in GrowAndShrinkNewSpace when the (Closed)

Created:
8 years, 8 months ago by Erik Corry

Modified:
8 years, 8 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

Fix spurious bugs in GrowAndShrinkNewSpace when the min and max new space sizes are equal. Committed: https://code.google.com/p/v8/source/detail?r=11456

Patch Set 2 : #

Total comments: 1

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -0 lines)			Patch
	M	test/cctest/test-heap.cc	View	1	2 chunks	+13 lines, -0 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

https://chromiumcodereview.appspot.com/10241002/diff/4001/test/cctest/test-heap.cc File test/cctest/test-heap.cc (right): https://chromiumcodereview.appspot.com/10241002/diff/4001/test/cctest/test-heap.cc#newcode1278 test/cctest/test-heap.cc:1278: if (HEAP->ReservedSemiSpaceSize() == HEAP->InitialSemiSpaceSize()) { Shouldn't the test say ...

8 years, 8 months ago (2012-04-26 14:41:45 UTC) #3