Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Unified Diff: tools/testing/dart/test_runner.dart

Issue 10239001: Cancel timout in test_runner.dart if RunningProcess transfers control to BatchRunnerProcess (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_runner.dart
diff --git a/tools/testing/dart/test_runner.dart b/tools/testing/dart/test_runner.dart
index a95e1ee20d8ecff6a8ef2764cd9a8c1ad8225ba8..e712f7e6659a427d5a513601bfabcfde726da50b 100644
--- a/tools/testing/dart/test_runner.dart
+++ b/tools/testing/dart/test_runner.dart
@@ -564,6 +564,9 @@ class RunningProcess {
!testCase.configuration['noBatch']) {
// Note: processQueue will always be non-null for runtime == ie, ff,
// safari, chrome, opera. (It is only null for runtime == vm)
+ // This RunningProcess object is done, and hands over control to
+ // BatchRunner.startTest(), which handles reporting, etc.
+ timeoutTimer.cancel();
processQueue._getBatchRunner(testCase).startTest(testCase);
} else {
runCommand(testCase.commands[currentStep++], stepExitHandler);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698