Issue 10238014: Fix search engine automation hooks to work with multiple profiles.

Issue 10238014: Fix search engine automation hooks to work with multiple profiles. (Closed)

Created:
8 years, 8 months ago by kkania

Modified:
8 years, 8 months ago

Reviewers:
dennis_jeffrey

CC:
chromium-reviews, Nirnimesh, kkania, anantha, robertshield, dyu1, dennis_jeffrey, prachij

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix search engine automation hooks to work with multiple profiles. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134202

Patch Set 2 : . #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -21 lines)			Patch
M	chrome/browser/automation/automation_provider_observers.h	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/automation/automation_provider_observers.cc	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/automation/testing_automation_provider.cc	View		3 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/test/pyautolib/pyauto.py	View	1	4 chunks	+29 lines, -15 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

dennis_jeffrey

LGTM with nits. https://chromiumcodereview.appspot.com/10238014/diff/2001/chrome/test/pyautolib/pyauto.py File chrome/test/pyautolib/pyauto.py (right): https://chromiumcodereview.appspot.com/10238014/diff/2001/chrome/test/pyautolib/pyauto.py#newcode1209 chrome/test/pyautolib/pyauto.py:1209: window_index: The window index, default is ...

8 years, 8 months ago (2012-04-26 20:42:44 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kkania@chromium.org/10238014/6001

8 years, 8 months ago (2012-04-26 23:26:35 UTC) #3

Change committed as 134202

Expand Messages | Collapse Messages