Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Unified Diff: tools/testing/perf_testing/run_perf_tests.py

Issue 10238013: Don't run Dartium on JS perf tests. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/perf_testing/run_perf_tests.py
===================================================================
--- tools/testing/perf_testing/run_perf_tests.py (revision 7041)
+++ tools/testing/perf_testing/run_perf_tests.py (working copy)
@@ -397,8 +397,10 @@
class BrowserTester(Tester):
@staticmethod
- def get_browsers():
- browsers = ['dartium', 'ff', 'chrome']
+ def get_browsers(add_dartium=True):
+ browsers = ['ff', 'chrome']
+ if add_dartium:
+ browsers += ['dartium']
has_shell = False
if platform.system() == 'Darwin':
browsers += ['safari']
@@ -425,7 +427,7 @@
"""Args:
test_runner: Reference to the object that notifies us when to run."""
super(CommonBrowserTest, self).__init__(
- self.name(), BrowserTester.get_browsers(),
+ self.name(), BrowserTester.get_browsers(False),
'browser', ['js', 'frog'],
self.get_standalone_benchmarks(), test_runner,
self.CommonBrowserTester(self),
@@ -450,7 +452,7 @@
'make_web_benchmarks.py')])
os.chdir('..')
- for browser in BrowserTester.get_browsers():
+ for browser in self.test.platform_list:
for version in self.test.versions:
if not self.test.is_valid_combination(browser, version):
continue
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698