Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Unified Diff: lib/compiler/implementation/ssa/codegen.dart

Issue 10236007: Revert "Avoid "=== true" inside code by calling a function that does this for us." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/compiler/implementation/ssa/builder.dart ('k') | lib/compiler/implementation/ssa/nodes.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/ssa/codegen.dart
diff --git a/lib/compiler/implementation/ssa/codegen.dart b/lib/compiler/implementation/ssa/codegen.dart
index 8fb92bbedf9b37e8aac4eaee3af754d4de519ca5..d9bce2986df5eef035ed2ea890a10133e68af863 100644
--- a/lib/compiler/implementation/ssa/codegen.dart
+++ b/lib/compiler/implementation/ssa/codegen.dart
@@ -127,7 +127,6 @@ class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {
final Equivalence<HPhi> phiEquivalence;
Element equalsNullElement;
- Element boolifiedEqualsNullElement;
int indent = 0;
int expectedPrecedence = JSPrecedence.STATEMENT_PRECEDENCE;
HGraph currentGraph;
@@ -177,10 +176,8 @@ class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {
// Create a namespace for temporaries.
prefixes[TEMPORARY_PREFIX] = 0;
- Interceptors interceptors = compiler.builder.interceptors;
- equalsNullElement = interceptors.getEqualsNullInterceptor();
- boolifiedEqualsNullElement =
- interceptors.getBoolifiedVersionOf(equalsNullElement);
+ equalsNullElement =
+ compiler.builder.interceptors.getEqualsNullInterceptor();
}
abstract visitTypeGuard(HTypeGuard node);
@@ -860,8 +857,7 @@ class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {
buffer.add(' === ');
use(node.right, JSPrecedence.RELATIONAL_PRECEDENCE);
endExpression(JSPrecedence.EQUALITY_PRECEDENCE);
- } else if (node.element === equalsNullElement ||
- node.element === boolifiedEqualsNullElement) {
+ } else if (node.element === equalsNullElement) {
beginExpression(JSPrecedence.CALL_PRECEDENCE);
use(node.target, JSPrecedence.CALL_PRECEDENCE);
buffer.add('(');
« no previous file with comments | « lib/compiler/implementation/ssa/builder.dart ('k') | lib/compiler/implementation/ssa/nodes.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698