Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: lib/compiler/implementation/lib/js_helper.dart

Issue 10236007: Revert "Avoid "=== true" inside code by calling a function that does this for us." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « frog/tests/leg/src/mock_compiler.dart ('k') | lib/compiler/implementation/ssa/builder.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/lib/js_helper.dart
diff --git a/lib/compiler/implementation/lib/js_helper.dart b/lib/compiler/implementation/lib/js_helper.dart
index 1b87d6d2dc21df8c56d284fceebd6c54ff439ece..7dbccc9254214c0a35c9875ed25512e6891f7edd 100644
--- a/lib/compiler/implementation/lib/js_helper.dart
+++ b/lib/compiler/implementation/lib/js_helper.dart
@@ -96,7 +96,7 @@ tdiv(var a, var b) {
eq(var a, var b) {
if (JS('bool', @'typeof # === "object"', a)) {
if (JS_HAS_EQUALS(a)) {
- return UNINTERCEPTED(a == b);
+ return UNINTERCEPTED(a == b) === true;
} else {
return JS('bool', @'# === #', a, b);
}
@@ -105,8 +105,6 @@ eq(var a, var b) {
return JS('bool', @'# === #', a, b);
}
-bool eqB(var a, var b) => eq(a, b) === true;
-
eqq(var a, var b) {
return JS('bool', @'# === #', a, b);
}
@@ -114,7 +112,7 @@ eqq(var a, var b) {
eqNull(var a) {
if (JS('bool', @'typeof # === "object"', a)) {
if (JS_HAS_EQUALS(a)) {
- return UNINTERCEPTED(a == null);
+ return UNINTERCEPTED(a == null) === true;
} else {
return false;
}
@@ -123,8 +121,6 @@ eqNull(var a) {
}
}
-bool eqNullB(var a) => eqNull(a) === true;
-
gt(var a, var b) {
if (checkNumbers(a, b)) {
return JS('bool', @'# > #', a, b);
@@ -132,8 +128,6 @@ gt(var a, var b) {
return UNINTERCEPTED(a > b);
}
-bool gtB(var a, var b) => gt(a, b) === true;
-
ge(var a, var b) {
if (checkNumbers(a, b)) {
return JS('bool', @'# >= #', a, b);
@@ -141,8 +135,6 @@ ge(var a, var b) {
return UNINTERCEPTED(a >= b);
}
-bool geB(var a, var b) => ge(a, b) === true;
-
lt(var a, var b) {
if (checkNumbers(a, b)) {
return JS('bool', @'# < #', a, b);
@@ -150,8 +142,6 @@ lt(var a, var b) {
return UNINTERCEPTED(a < b);
}
-bool ltB(var a, var b) => lt(a, b) === true;
-
le(var a, var b) {
if (checkNumbers(a, b)) {
return JS('bool', @'# <= #', a, b);
@@ -159,8 +149,6 @@ le(var a, var b) {
return UNINTERCEPTED(a <= b);
}
-bool leB(var a, var b) => le(a, b) === true;
-
shl(var a, var b) {
// TODO(floitsch): inputs must be integers.
if (checkNumbers(a, b)) {
« no previous file with comments | « frog/tests/leg/src/mock_compiler.dart ('k') | lib/compiler/implementation/ssa/builder.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698