Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 10235006: Print compare-state with --print-code-stubs. (Closed)

Created:
8 years, 8 months ago by Michael Starzinger
Modified:
8 years, 8 months ago
CC:
v8-dev
Visibility:
Public.

Description

Print compare-state with --print-code-stubs. R=vegorov@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=11457

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comment by Vyacheslav Egorov. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -10 lines) Patch
M src/code-stubs.cc View 1 2 chunks +9 lines, -10 lines 0 comments Download
M src/objects.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
8 years, 8 months ago (2012-04-26 15:37:05 UTC) #1
Vyacheslav Egorov (Chromium)
lgtm https://chromiumcodereview.appspot.com/10235006/diff/1/src/code-stubs.cc File src/code-stubs.cc (right): https://chromiumcodereview.appspot.com/10235006/diff/1/src/code-stubs.cc#newcode121 src/code-stubs.cc:121: RecordCodeGeneration(*new_object, &masm); I think more logical would be ...
8 years, 8 months ago (2012-04-26 15:39:51 UTC) #2
Michael Starzinger
8 years, 8 months ago (2012-04-26 16:19:58 UTC) #3
Added new patch set.

https://chromiumcodereview.appspot.com/10235006/diff/1/src/code-stubs.cc
File src/code-stubs.cc (right):

https://chromiumcodereview.appspot.com/10235006/diff/1/src/code-stubs.cc#newc...
src/code-stubs.cc:121: RecordCodeGeneration(*new_object, &masm);
On 2012/04/26 15:39:51, Vyacheslav Egorov wrote:
> I think more logical would be to move code->set_major_key(MajorKey()); out of
> RecordCodeGeneration to here and then move RecordCodeGeneration down after
> FinishCode.
> 
> Recording generation of unfinished code looks strange.

Done. But I still left the printing here. Because IMHO printing code has nothing
to do with recording code generation.

Powered by Google App Engine
This is Rietveld 408576698