Issue 10234007: Remove more assumptions from debug tests. Even though a function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10234007: Remove more assumptions from debug tests. Even though a function (Closed)

Created:
8 years, 8 months ago by Erik Corry

Modified:
8 years, 8 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

Remove more assumptions from debug tests. Even though a function is optimized, does not mean all frames on the stack are optimized. Also, when we ask for the list of scripts we may get more or less depending on GC timing. Also fixed a presubmit error and made %GetOptimizationStatus a little more honest. Committed: https://code.google.com/p/v8/source/detail?r=11455

Patch Set 1 #

Total comments: 2

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -34 lines)			Patch
M	src/runtime.cc	View	1 chunk	+5 lines, -2 lines	2 comments	Download
M	test/mjsunit/debug-evaluate-locals-optimized.js	View	2 chunks	+0 lines, -15 lines	0 comments	Download
M	test/mjsunit/debug-evaluate-locals-optimized-double.js	View	2 chunks	+0 lines, -15 lines	0 comments	Download
M	test/mjsunit/debug-scripts-request.js	View	1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Yang

LGTM with one comment. https://chromiumcodereview.appspot.com/10234007/diff/1/src/runtime.cc File src/runtime.cc (right): https://chromiumcodereview.appspot.com/10234007/diff/1/src/runtime.cc#newcode8323 src/runtime.cc:8323: return function->IsOptimized() ? Smi::FromInt(3) // ...

8 years, 8 months ago (2012-04-26 13:42:20 UTC) #2

Erik Corry

8 years, 8 months ago (2012-04-26 13:46:10 UTC) #3

https://chromiumcodereview.appspot.com/10234007/diff/1/src/runtime.cc
File src/runtime.cc (right):

https://chromiumcodereview.appspot.com/10234007/diff/1/src/runtime.cc#newcode...
src/runtime.cc:8323: return function->IsOptimized() ? Smi::FromInt(3)   // 1 ==
"always".
On 2012/04/26 13:42:20, Yang wrote:
> Should the comment be '3 == "always"'?

Done.

Expand Messages | Collapse Messages