Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 10234004: Make Error.prototype.name writable again, as required by the spec and the web. (Closed)

Created:
8 years, 8 months ago by rossberg
Modified:
8 years, 7 months ago
Reviewers:
danno
CC:
v8-dev
Visibility:
Public.

Description

Make Error.prototype.name writable again, as required by the spec and the web. Address http://code.google.com/p/chromium/issues/detail?id=69187 by instead ignoring getters on ReferenceError.prototype.name in Error.prototype.toString. And while we're at it, do the same for SyntaxError and TypeError, and the properties "message", "type", and "arguments" on all of them, which potentially have similar issues. R=danno@chromium.org BUG=69187 TEST= Committed: https://code.google.com/p/v8/source/detail?r=11529

Patch Set 1 #

Patch Set 2 : Added test case for use of MakeError. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -48 lines) Patch
M src/messages.js View 3 chunks +32 lines, -15 lines 0 comments Download
M test/mjsunit/error-constructors.js View 1 2 chunks +68 lines, -33 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
rossberg
8 years, 8 months ago (2012-04-26 09:48:19 UTC) #1
danno
As discussed, do you also have to make sure that setters cannot be installed to ...
8 years, 7 months ago (2012-05-08 14:10:00 UTC) #2
rossberg
On 2012/05/08 14:10:00, danno wrote: > As discussed, do you also have to make sure ...
8 years, 7 months ago (2012-05-08 15:07:02 UTC) #3
danno
8 years, 7 months ago (2012-05-08 16:17:02 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698