Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 10233019: MIPS: Reduce size of LIR instruction by one word and remove dead code. (Closed)

Created:
8 years, 8 months ago by palfia
Modified:
8 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Reduce size of LIR instruction by one word and remove dead code. Port r11454 (72c662fc) Original commit message: Reduce size of LIR instruction by one word and remove dead code. Until now we always recorded two deoptimization environments for instructions that are marked as calls. We actually don't need two for all LIR instructions except one (LInstanceOfKnownGlobal) where there is a lazy deoptimization point in deferred code. This change remove on of them and uses one virtual function instead to make LInstanceOfKnownGlobal work as before. Additionally, this change removes an unused predicate save_doubles_ from LIR instructions and removes some helper functions that are used only in one place. BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=11501

Patch Set 1 #

Patch Set 2 : Rebased on r11482 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M src/mips/lithium-codegen-mips.cc View 1 5 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
palfia
8 years, 8 months ago (2012-04-26 19:51:05 UTC) #1
palfia
Rebased on r11482
8 years, 7 months ago (2012-05-02 20:09:23 UTC) #2
danno
8 years, 7 months ago (2012-05-03 15:07:36 UTC) #3
LGTM. Landing.

Powered by Google App Engine
This is Rietveld 408576698