content/browser/speech/speech_recognition_manager_impl.cc - Issue 10233010: Introducing new data types and IPC messages for scripted JS speech recognition APIs (Speech CL2.0)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/speech/speech_recognition_manager_impl.cc

Issue 10233010: Introducing new data types and IPC messages for scripted JS speech recognition APIs (Speech CL2.0) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixed according to Hans review. Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/speech/speech_recognition_engine.cc ('K') | « content/browser/speech/speech_recognition_engine.cc ('k') | content/browser/speech/speech_recognizer_impl.cc » ('j') | content/common/speech_recognition_messages.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/speech/speech_recognition_manager_impl.cc

diff --git a/content/browser/speech/speech_recognition_manager_impl.cc b/content/browser/speech/speech_recognition_manager_impl.cc

index da2737cf2be5ef2bf46cd284ab469324f9d5a7f8..144dd28d3244566378ab86e2b16e0f61e774fd97 100644

--- a/content/browser/speech/speech_recognition_manager_impl.cc

+++ b/content/browser/speech/speech_recognition_manager_impl.cc

@@ -76,9 +76,9 @@ int SpeechRecognitionManagerImpl::CreateSession(

if (delegate_)

delegate_->GetDiagnosticInformation(&can_report_metrics, &hardware_info);

- GoogleOneShotRemoteEngineConfig remote_engine_config;

+ SpeechRecognitionEngineConfig remote_engine_config;

remote_engine_config.language = config.language;

- remote_engine_config.grammar = config.grammar;

+ remote_engine_config.grammars = config.grammars;

remote_engine_config.audio_sample_rate =

SpeechRecognizerImpl::kAudioSampleRate;

remote_engine_config.audio_num_bits_per_sample =

@@ -87,8 +87,8 @@ int SpeechRecognitionManagerImpl::CreateSession(

remote_engine_config.hardware_info = hardware_info;

remote_engine_config.origin_url = can_report_metrics ? config.origin_url : "";

- GoogleOneShotRemoteEngine* google_remote_engine =

- new GoogleOneShotRemoteEngine(config.url_request_context_getter);

+ SpeechRecognitionEngine* google_remote_engine =

+ new GoogleOneShotRemoteEngine(config.url_request_context_getter);

google_remote_engine->SetConfig(remote_engine_config);

session.recognizer = new SpeechRecognizerImpl(this,