content/browser/speech/input_tag_speech_dispatcher_host.cc - Issue 10233010: Introducing new data types and IPC messages for scripted JS speech recognition APIs (Speech CL2.0)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/speech/input_tag_speech_dispatcher_host.cc

Issue 10233010: Introducing new data types and IPC messages for scripted JS speech recognition APIs (Speech CL2.0) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixed according to Hans review. Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/speech/google_one_shot_remote_engine.cc ('K') | « content/browser/speech/google_one_shot_remote_engine.cc ('k') | content/browser/speech/speech_recognition_browsertest.cc » ('j') | content/browser/speech/speech_recognition_engine.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/speech/input_tag_speech_dispatcher_host.cc

diff --git a/content/browser/speech/input_tag_speech_dispatcher_host.cc b/content/browser/speech/input_tag_speech_dispatcher_host.cc

index 4831ecd48c68db33dfd7960a9af6d467a0576541..8fd225a084166ef0f00a0fea5c688f7e9fb493c0 100644

--- a/content/browser/speech/input_tag_speech_dispatcher_host.cc

+++ b/content/browser/speech/input_tag_speech_dispatcher_host.cc

@@ -100,7 +100,9 @@ void InputTagSpeechDispatcherHost::OnStartRecognition(

SpeechRecognitionSessionConfig config;

config.language = params.language;

- config.grammar = params.grammar;

+ if (!params.grammar.empty())

Satish 2012/04/27 10:04:41 suggest using braces here since the body of the if

Primiano Tucci (use gerrit) 2012/04/27 15:58:44 Done.

+ config.grammars.push_back(

+ content::SpeechRecognitionGrammar(params.grammar));

config.origin_url = params.origin_url;

config.initial_context = context;

config.url_request_context_getter = url_request_context_getter_.get();