Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2060)

Unified Diff: content/browser/speech/google_one_shot_remote_engine.h

Issue 10233010: Introducing new data types and IPC messages for scripted JS speech recognition APIs (Speech CL2.0) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed according to Hans review. Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/speech/google_one_shot_remote_engine.h
diff --git a/content/browser/speech/google_one_shot_remote_engine.h b/content/browser/speech/google_one_shot_remote_engine.h
index 7e47c67dd68b4c323d21337662b595d6a507beba..180ad137e75dda5252ca651c5e37bf2c41b2606e 100644
--- a/content/browser/speech/google_one_shot_remote_engine.h
+++ b/content/browser/speech/google_one_shot_remote_engine.h
@@ -31,19 +31,6 @@ namespace speech {
class AudioChunk;
-struct CONTENT_EXPORT GoogleOneShotRemoteEngineConfig {
- std::string language;
- std::string grammar;
- bool filter_profanities;
- std::string hardware_info;
- std::string origin_url;
- int audio_sample_rate;
- int audio_num_bits_per_sample;
-
- GoogleOneShotRemoteEngineConfig();
- ~GoogleOneShotRemoteEngineConfig();
-};
-
// Implements a SpeechRecognitionEngine by means of remote interaction with
// Google speech recognition webservice.
class CONTENT_EXPORT GoogleOneShotRemoteEngine
@@ -57,9 +44,9 @@ class CONTENT_EXPORT GoogleOneShotRemoteEngine
explicit GoogleOneShotRemoteEngine(net::URLRequestContextGetter* context);
virtual ~GoogleOneShotRemoteEngine();
- void SetConfig(const GoogleOneShotRemoteEngineConfig& config);
// SpeechRecognitionEngine methods.
+ virtual void SetConfig(const SpeechRecognitionEngineConfig& config) OVERRIDE;
virtual void StartRecognition() OVERRIDE;
virtual void EndRecognition() OVERRIDE;
virtual void TakeAudioChunk(const AudioChunk& data) OVERRIDE;
@@ -71,7 +58,7 @@ class CONTENT_EXPORT GoogleOneShotRemoteEngine
virtual void OnURLFetchComplete(const content::URLFetcher* source) OVERRIDE;
private:
- GoogleOneShotRemoteEngineConfig config_;
+ SpeechRecognitionEngineConfig config_;
scoped_ptr<content::URLFetcher> url_fetcher_;
scoped_refptr<net::URLRequestContextGetter> url_context_;
scoped_ptr<AudioEncoder> encoder_;

Powered by Google App Engine
This is Rietveld 408576698