Issue 10233004: Reduce expense of TraceGVN when --trace-gvn is off

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10233004: Reduce expense of TraceGVN when --trace-gvn is off (Closed)

Created:
8 years, 8 months ago by danno

Modified:
8 years, 8 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Reduce expense of TraceGVN when --trace-gvn is off R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=11444

Patch Set 1 #

Total comments: 1

Patch Set 2 : Review feedback #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+76 lines, -46 lines)			Patch
	M	src/hydrogen.cc	View	1	9 chunks	+76 lines, -46 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

8 years, 8 months ago (2012-04-26 08:53:47 UTC) #2

LGTM (with a nit). Wouldn't it be awesome if there were var-args in macros? I
would give a lot for that!

https://chromiumcodereview.appspot.com/10233004/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):

https://chromiumcodereview.appspot.com/10233004/diff/1/src/hydrogen.cc#newcod...
src/hydrogen.cc:1736: TRACE_GVN_4("Checking dependencies on
HTransitionElementsKind %d (%s) "
This line is longer than 80 characters.

Expand Messages | Collapse Messages