Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Unified Diff: Source/WebCore/bindings/v8/WorkerScriptController.cpp

Issue 10232019: Merge 113818 - Notify observers of WorkerRunLoop stopping before the V8 isolate dies. (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/1084/
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/WebCore/bindings/v8/WorkerScriptController.cpp
===================================================================
--- Source/WebCore/bindings/v8/WorkerScriptController.cpp (revision 115369)
+++ Source/WebCore/bindings/v8/WorkerScriptController.cpp (working copy)
@@ -65,6 +65,12 @@
WorkerScriptController::~WorkerScriptController()
{
removeAllDOMObjects();
+#if PLATFORM(CHROMIUM)
+ // The corresponding call to didStartWorkerRunLoop is in
+ // WorkerThread::workerThread().
+ // See http://webkit.org/b/83104#c14 for why this is here.
+ PlatformSupport::didStopWorkerRunLoop(&m_workerContext->thread()->runLoop());
+#endif
m_proxy.clear();
m_isolate->Exit();
V8BindingPerIsolateData::dispose(m_isolate);
« no previous file with comments | « LayoutTests/storage/indexeddb/resources/pending-version-change-on-exit.js ('k') | Source/WebCore/workers/WorkerThread.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698