Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Side by Side Diff: chrome/browser/extensions/api/extension_action/extension_browser_actions_api_unittest.cc

Issue 10231002: Fully merge the implementations of the browserAction and pageAction APIs (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <string> 5 #include <string>
6 6
7 #include "base/values.h" 7 #include "base/values.h"
8 #include "chrome/browser/extensions/api/extension_action/extension_actions_api.h "
8 #include "chrome/common/extensions/extension.h" 9 #include "chrome/common/extensions/extension.h"
9 #include "chrome/browser/extensions/api/extension_action/extension_browser_actio ns_api.h" 10 #include "third_party/skia/include/core/SkColor.h"
10 #include "testing/gtest/include/gtest/gtest.h" 11 #include "testing/gtest/include/gtest/gtest.h"
11 12
12 void RunPassTest(const std::string& css_string, SkColor expected_result) { 13 void RunPassTest(const std::string& css_string, SkColor expected_result) {
13 SkColor color = 0; 14 SkColor color = 0;
14 EXPECT_TRUE(BrowserActionFunction::ParseCSSColorString(css_string, &color)); 15 EXPECT_TRUE(
16 ExtensionActionFunction::ParseCSSColorString(css_string, &color));
15 EXPECT_EQ(color, expected_result); 17 EXPECT_EQ(color, expected_result);
16 } 18 }
17 19
18 void RunFailTest(const std::string& css_string) { 20 void RunFailTest(const std::string& css_string) {
19 SkColor color = 0; 21 SkColor color = 0;
20 EXPECT_FALSE(BrowserActionFunction::ParseCSSColorString(css_string, &color)); 22 EXPECT_FALSE(
23 ExtensionActionFunction::ParseCSSColorString(css_string, &color));
21 } 24 }
22 25
23 TEST(ExtensionBrowserActionsApiTest, ChangeBadgeBackgroundNormalCSS) { 26 TEST(ExtensionBrowserActionsApiTest, ChangeBadgeBackgroundNormalCSS) {
24 RunPassTest("#34006A", SkColorSetARGB(0xFF, 0x34, 0, 0x6A)); 27 RunPassTest("#34006A", SkColorSetARGB(0xFF, 0x34, 0, 0x6A));
25 } 28 }
26 29
27 TEST(ExtensionBrowserActionsApiTest, ChangeBadgeBackgroundShortCSS) { 30 TEST(ExtensionBrowserActionsApiTest, ChangeBadgeBackgroundShortCSS) {
28 RunPassTest("#A1E", SkColorSetARGB(0xFF, 0xAA, 0x11, 0xEE)); 31 RunPassTest("#A1E", SkColorSetARGB(0xFF, 0xAA, 0x11, 0xEE));
29 } 32 }
30 33
31 TEST(ExtensionBrowserActionsApiTest, ChangeBadgeBackgroundCSSNoHash) { 34 TEST(ExtensionBrowserActionsApiTest, ChangeBadgeBackgroundCSSNoHash) {
32 RunFailTest("11FF22"); 35 RunFailTest("11FF22");
33 } 36 }
34 37
35 TEST(ExtensionBrowserActionsApiTest, ChangeBadgeBackgroundCSSTooShort) { 38 TEST(ExtensionBrowserActionsApiTest, ChangeBadgeBackgroundCSSTooShort) {
36 RunFailTest("#FF22"); 39 RunFailTest("#FF22");
37 } 40 }
38 41
39 TEST(ExtensionBrowserActionsApiTest, ChangeBadgeBackgroundCSSTooLong) { 42 TEST(ExtensionBrowserActionsApiTest, ChangeBadgeBackgroundCSSTooLong) {
40 RunFailTest("#FF22128"); 43 RunFailTest("#FF22128");
41 } 44 }
42 45
43 TEST(ExtensionBrowserActionsApiTest, ChangeBadgeBackgroundCSSInvalid) { 46 TEST(ExtensionBrowserActionsApiTest, ChangeBadgeBackgroundCSSInvalid) {
44 RunFailTest("#-22128"); 47 RunFailTest("#-22128");
45 } 48 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698