Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Issue 10230016: Fix a couple of minor issues and try to resolve #2740. (Closed)

Created:
8 years, 8 months ago by Bob Nystrom
Modified:
8 years, 8 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix a couple of minor issues and try to resolve #2740. Committed: https://code.google.com/p/dart/source/detail?r=7087

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -17 lines) Patch
M utils/pub/package.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/tests/pub/pub.status View 1 chunk +0 lines, -3 lines 0 comments Download
M utils/tests/pub/test_pub.dart View 6 chunks +31 lines, -13 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
Bob Nystrom
I'm trying to address http://code.google.com/p/dart/issues/detail?id=2740 here. The actual fix for the issue should have been ...
8 years, 8 months ago (2012-04-26 22:02:05 UTC) #1
nweiz
lgtm https://chromiumcodereview.appspot.com/10230016/diff/1/utils/tests/pub/test_pub.dart File utils/tests/pub/test_pub.dart (right): https://chromiumcodereview.appspot.com/10230016/diff/1/utils/tests/pub/test_pub.dart#newcode92 utils/tests/pub/test_pub.dart:92: return createTempDir('pub-test-sandbox-'); Why?
8 years, 8 months ago (2012-04-26 23:42:47 UTC) #2
Mads Ager (google)
LGTM, thanks! Yes, I was seeing this on my local Linux machine. The good news ...
8 years, 8 months ago (2012-04-27 06:10:24 UTC) #3
Bob Nystrom
8 years, 8 months ago (2012-04-27 15:46:53 UTC) #4
On 2012/04/26 23:42:47, nweiz wrote:
> lgtm
> 
>
https://chromiumcodereview.appspot.com/10230016/diff/1/utils/tests/pub/test_p...
> File utils/tests/pub/test_pub.dart (right):
> 
>
https://chromiumcodereview.appspot.com/10230016/diff/1/utils/tests/pub/test_p...
> utils/tests/pub/test_pub.dart:92: return createTempDir('pub-test-sandbox-');
> Why?

If I run test.py with -m all I see some strange errors if I don't do this. I
believe test.dart may be running different test configurations in parallel which
does horrendously bad things if they happen to be accessing the same files. This
ensures each invocation is nicely sandboxed.

Powered by Google App Engine
This is Rietveld 408576698