Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Unified Diff: media/base/buffers.h

Issue 10228017: Add initial implementation of SourceBufferStream (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/base/buffers.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/buffers.h
diff --git a/media/base/buffers.h b/media/base/buffers.h
index f4e42642b4f240ce961d987094d59e80365c5dcb..b98b8ae32adf87d7acccdb7618a158b03aa6fb11 100644
--- a/media/base/buffers.h
+++ b/media/base/buffers.h
@@ -27,6 +27,7 @@
#define MEDIA_BASE_BUFFERS_H_
#include "base/basictypes.h"
+#include "base/logging.h"
#include "base/memory/ref_counted.h"
#include "base/time.h"
#include "media/base/media_export.h"
@@ -73,6 +74,17 @@ class MEDIA_EXPORT Buffer : public base::RefCountedThreadSafe<Buffer> {
duration_ = duration;
}
+ virtual bool IsKeyframe() const {
scherkus (not reviewing) 2012/04/25 22:59:00 don't inline virtual methods in .h http://dev.chro
vrk (LEFT CHROMIUM) 2012/04/25 23:25:48 Yeahhh as I explained offline, I was worried that
+ // TODO(vrk): Remove this when keyframes are marked as such.
+ NOTIMPLEMENTED();
+
+ return is_keyframe_;
+ }
+
+ void SetKeyframe(bool is_keyframe) {
+ is_keyframe_ = is_keyframe;
+ }
+
protected:
friend class base::RefCountedThreadSafe<Buffer>;
Buffer(base::TimeDelta timestamp, base::TimeDelta duration);
@@ -81,6 +93,7 @@ class MEDIA_EXPORT Buffer : public base::RefCountedThreadSafe<Buffer> {
private:
base::TimeDelta timestamp_;
base::TimeDelta duration_;
+ bool is_keyframe_;
DISALLOW_COPY_AND_ASSIGN(Buffer);
};
« no previous file with comments | « no previous file | media/base/buffers.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698