Add initial implementation of SourceBufferStream

media/base/buffers.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Defines a base class for representing timestamped media data. Every buffer
 // contains a timestamp in microseconds describing the relative position of
 // the buffer within the media stream, and the duration in microseconds for
 // the length of time the buffer will be rendered.
 //
 // Timestamps are derived directly from the encoded media file and are commonly
@@ skipping 55 matching lines @@
     timestamp_ = timestamp;
   }
 
   base::TimeDelta GetDuration() const {
     return duration_;
   }
   void SetDuration(const base::TimeDelta& duration) {
     duration_ = duration;
   }
 
+  // TODO(vrk): Only ChunkDemuxer and friends care about keyframes.
+  // Put keyframe stuff inside a derived class of Buffer?

[acolwell GONE FROM CHROMIUM, 2012/04/29 18:13:06]

I think you should remove this TODO. ISTM if we really were worried about this
we'd do this right now instead of temporarily putting this method here.

[vrk (LEFT CHROMIUM), 2012/05/01 22:51:13]

Done.

+  bool IsKeyframe() const { return is_keyframe_; }
+
  protected:
   friend class base::RefCountedThreadSafe<Buffer>;
   Buffer(base::TimeDelta timestamp, base::TimeDelta duration);
+  Buffer(base::TimeDelta timestamp, base::TimeDelta duration, bool is_keyframe);

[acolwell GONE FROM CHROMIUM, 2012/04/29 18:13:06]

I think we should be able to get away with just adding the parameter to the
existing constructor. It doesn't look like there are too many call sites to
update. 
You should probably make the buffer changes a different CL so we can focus on
just those changes. 

[vrk (LEFT CHROMIUM), 2012/05/01 22:51:13]

Done, CL here:
https://chromiumcodereview.appspot.com/10269022/

   virtual ~Buffer();
 
  private:
   base::TimeDelta timestamp_;
   base::TimeDelta duration_;
+  bool is_keyframe_;
 
   DISALLOW_COPY_AND_ASSIGN(Buffer);
 };
 
 }  // namespace media
 
 #endif  // MEDIA_BASE_BUFFERS_H_