Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Side by Side Diff: runtime/vm/flow_graph_compiler_x64.cc

Issue 10228001: Turn more explicitly named temps into uses of definitions. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/flow_graph_builder.cc ('k') | runtime/vm/intermediate_language.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_X64. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_X64.
6 #if defined(TARGET_ARCH_X64) 6 #if defined(TARGET_ARCH_X64)
7 7
8 #include "vm/flow_graph_compiler.h" 8 #include "vm/flow_graph_compiler.h"
9 9
10 #include "lib/error.h" 10 #include "lib/error.h"
(...skipping 514 matching lines...) Expand 10 before | Expand all | Expand 10 after
525 __ movq(RAX, CTX); 525 __ movq(RAX, CTX);
526 } 526 }
527 527
528 528
529 void FlowGraphCompiler::VisitStoreContext(StoreContextComp* comp) { 529 void FlowGraphCompiler::VisitStoreContext(StoreContextComp* comp) {
530 LoadValue(CTX, comp->value()); 530 LoadValue(CTX, comp->value());
531 } 531 }
532 532
533 533
534 void FlowGraphCompiler::VisitClosureCall(ClosureCallComp* comp) { 534 void FlowGraphCompiler::VisitClosureCall(ClosureCallComp* comp) {
535 ASSERT(comp->context()->IsTemp()); 535 ASSERT(comp->context()->IsTemp() || comp->context()->IsUse());
536 ASSERT(VerifyCallComputation(comp)); 536 ASSERT(VerifyCallComputation(comp));
537 // The arguments to the stub include the closure. The arguments 537 // The arguments to the stub include the closure. The arguments
538 // descriptor describes the closure's arguments (and so does not include 538 // descriptor describes the closure's arguments (and so does not include
539 // the closure). 539 // the closure).
540 int argument_count = comp->ArgumentCount(); 540 int argument_count = comp->ArgumentCount();
541 const Array& arguments_descriptor = 541 const Array& arguments_descriptor =
542 CodeGenerator::ArgumentsDescriptor(argument_count - 1, 542 CodeGenerator::ArgumentsDescriptor(argument_count - 1,
543 comp->argument_names()); 543 comp->argument_names());
544 __ LoadObject(R10, arguments_descriptor); 544 __ LoadObject(R10, arguments_descriptor);
545 545
(...skipping 1176 matching lines...) Expand 10 before | Expand all | Expand 10 after
1722 ASSERT(exception_handlers_list_ != NULL); 1722 ASSERT(exception_handlers_list_ != NULL);
1723 const ExceptionHandlers& handlers = ExceptionHandlers::Handle( 1723 const ExceptionHandlers& handlers = ExceptionHandlers::Handle(
1724 exception_handlers_list_->FinalizeExceptionHandlers(code.EntryPoint())); 1724 exception_handlers_list_->FinalizeExceptionHandlers(code.EntryPoint()));
1725 code.set_exception_handlers(handlers); 1725 code.set_exception_handlers(handlers);
1726 } 1726 }
1727 1727
1728 1728
1729 } // namespace dart 1729 } // namespace dart
1730 1730
1731 #endif // defined TARGET_ARCH_X64 1731 #endif // defined TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « runtime/vm/flow_graph_builder.cc ('k') | runtime/vm/intermediate_language.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698