Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3838)

Unified Diff: chrome/browser/webdata/web_data_service.h

Issue 10227014: Remove the very old code that migrated password data from the WebDataService to PasswordStore. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/webdata/web_data_service.h
===================================================================
--- chrome/browser/webdata/web_data_service.h (revision 133948)
+++ chrome/browser/webdata/web_data_service.h (working copy)
@@ -48,7 +48,6 @@
namespace webkit {
namespace forms {
struct FormField;
-struct PasswordForm;
}
}
@@ -79,7 +78,6 @@
BOOL_RESULT = 1, // WDResult<bool>
KEYWORDS_RESULT, // WDResult<WDKeywordsResult>
INT64_RESULT, // WDResult<int64>
- PASSWORD_RESULT, // WDResult<std::vector<PasswordForm*>>
#if defined(OS_WIN)
PASSWORD_IE7_RESULT, // WDResult<IE7PasswordInfo>
#endif
@@ -430,6 +428,7 @@
// Null on failure. Success is WDResult<std::vector<std::string> >
virtual Handle GetAllTokens(WebDataServiceConsumer* consumer);
+#if defined(OS_WIN)
//////////////////////////////////////////////////////////////////////////////
//
// Password manager
@@ -439,43 +438,6 @@
//
//////////////////////////////////////////////////////////////////////////////
- // Adds |form| to the list of remembered password forms.
- void AddLogin(const webkit::forms::PasswordForm& form);
-
- // Updates the remembered password form.
- void UpdateLogin(const webkit::forms::PasswordForm& form);
-
- // Removes |form| from the list of remembered password forms.
- void RemoveLogin(const webkit::forms::PasswordForm& form);
-
- // Removes all logins created in the specified daterange
- void RemoveLoginsCreatedBetween(const base::Time& delete_begin,
- const base::Time& delete_end);
-
- // Removes all logins created on or after the date passed in.
- void RemoveLoginsCreatedAfter(const base::Time& delete_begin);
-
- // Gets a list of password forms that match |form|.
- // |consumer| will be notified when the request is done. The result is of
- // type WDResult<std::vector<PasswordForm*>>.
- // The result will be null on failure. The |consumer| owns all PasswordForm's.
- Handle GetLogins(const webkit::forms::PasswordForm& form,
- WebDataServiceConsumer* consumer);
-
- // Gets the complete list of password forms that have not been blacklisted and
- // are thus auto-fillable.
- // |consumer| will be notified when the request is done. The result is of
- // type WDResult<std::vector<PasswordForm*>>.
- // The result will be null on failure. The |consumer| owns all PasswordForms.
- Handle GetAutofillableLogins(WebDataServiceConsumer* consumer);
-
- // Gets the complete list of password forms that have been blacklisted.
- // |consumer| will be notified when the request is done. The result is of
- // type WDResult<std::vector<PasswordForm*>>.
- // The result will be null on failure. The |consumer| owns all PasswordForm's.
- Handle GetBlacklistLogins(WebDataServiceConsumer* consumer);
-
-#if defined(OS_WIN)
// Adds |info| to the list of imported passwords from ie7/ie8.
void AddIE7Login(const IE7PasswordInfo& info);
@@ -686,20 +648,12 @@
GenericRequest2<std::string, std::string>* request);
void GetAllTokensImpl(GenericRequest<std::string>* request);
+#if defined(OS_WIN)
//////////////////////////////////////////////////////////////////////////////
//
// Password manager.
//
//////////////////////////////////////////////////////////////////////////////
- void AddLoginImpl(GenericRequest<webkit::forms::PasswordForm>* request);
- void UpdateLoginImpl(GenericRequest<webkit::forms::PasswordForm>* request);
- void RemoveLoginImpl(GenericRequest<webkit::forms::PasswordForm>* request);
- void RemoveLoginsCreatedBetweenImpl(
- GenericRequest2<base::Time, base::Time>* request);
- void GetLoginsImpl(GenericRequest<webkit::forms::PasswordForm>* request);
- void GetAutofillableLoginsImpl(WebDataRequest* request);
- void GetBlacklistLoginsImpl(WebDataRequest* request);
-#if defined(OS_WIN)
void AddIE7LoginImpl(GenericRequest<IE7PasswordInfo>* request);
void RemoveIE7LoginImpl(GenericRequest<IE7PasswordInfo>* request);
void GetIE7LoginImpl(GenericRequest<IE7PasswordInfo>* request);

Powered by Google App Engine
This is Rietveld 408576698