Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8549)

Unified Diff: chrome/browser/webdata/logins_table.h

Issue 10227014: Remove the very old code that migrated password data from the WebDataService to PasswordStore. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/webdata/logins_table.h
===================================================================
--- chrome/browser/webdata/logins_table.h (revision 133948)
+++ chrome/browser/webdata/logins_table.h (working copy)
@@ -11,43 +11,14 @@
#include "base/compiler_specific.h"
#include "chrome/browser/webdata/web_database_table.h"
-namespace base {
-class Time;
-}
-
-namespace webkit {
-namespace forms {
-struct PasswordForm;
-}
-}
-
#if defined(OS_WIN)
struct IE7PasswordInfo;
#endif
// This class manages the logins table within the SQLite database passed to the
-// constructor. It expects the following schemas:
-//
-// Note: The database stores time in seconds, UTC.
-//
-// logins
-// origin_url
-// action_url
-// username_element
-// username_value
-// password_element
-// password_value
-// submit_element
-// signon_realm The authority (scheme, host, port).
-// ssl_valid SSL status of page containing the form at first
-// impression.
-// preferred MRU bit.
-// date_created This column was added after logins support. "Legacy"
-// entries have a value of 0.
-// blacklisted_by_user Tracks whether or not the user opted to 'never
-// remember'
-// passwords for this site.
-//
+// constructor. We no longer store passwords here except for imported IE
+// passwords, so this class is now mostly responsible for deleting the table if
+// it is found to exist. (The data was migrated out long ago.)
class LoginsTable : public WebDatabaseTable {
public:
LoginsTable(sql::Connection* db, sql::MetaTable* meta_table)
@@ -56,9 +27,6 @@
virtual bool Init() OVERRIDE;
virtual bool IsSyncable() OVERRIDE;
- // Adds |form| to the list of remembered password forms.
- bool AddLogin(const webkit::forms::PasswordForm& form);
-
#if defined(OS_WIN)
// Adds |info| to the list of imported passwords from ie7/ie8.
bool AddIE7Login(const IE7PasswordInfo& info);
@@ -70,31 +38,6 @@
bool GetIE7Login(const IE7PasswordInfo& info, IE7PasswordInfo* result);
#endif
- // Updates remembered password form.
- bool UpdateLogin(const webkit::forms::PasswordForm& form);
-
- // Removes |form| from the list of remembered password forms.
- bool RemoveLogin(const webkit::forms::PasswordForm& form);
-
- // Removes all logins created from |delete_begin| onwards (inclusive) and
- // before |delete_end|. You may use a null Time value to do an unbounded
- // delete in either direction.
- bool RemoveLoginsCreatedBetween(base::Time delete_begin,
- base::Time delete_end);
-
- // Loads a list of matching password forms into the specified vector |forms|.
- // The list will contain all possibly relevant entries to the observed |form|,
- // including blacklisted matches.
- bool GetLogins(const webkit::forms::PasswordForm& form,
- std::vector<webkit::forms::PasswordForm*>* forms);
-
- // Loads the complete list of password forms into the specified vector |forms|
- // if include_blacklisted is true, otherwise only loads those which are
- // actually autofill-able; i.e haven't been blacklisted by the user selecting
- // the 'Never for this site' button.
- bool GetAllLogins(std::vector<webkit::forms::PasswordForm*>* forms,
- bool include_blacklisted);
-
private:
DISALLOW_COPY_AND_ASSIGN(LoginsTable);
};

Powered by Google App Engine
This is Rietveld 408576698