Remove the very old code that migrated password data from the WebDataService to PasswordStore.

Remove the very old code that migrated password data from the WebDataService to PasswordStore.
Anybody who was going to have their data migrated has long since had it done by now.

Also remove most of the code in the WebDataService that was responsible, long ago, for
managing the password data stored there. Only imported IE passwords are still stored there.

This change deletes over 1500 lines of old crufty code!
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=134155

[Mike Mammarella, 2012-04-26 02:42:35]

I'm just guessing at somebody who is probably familiar with the original
migration from WDS in the first place - if you have a better reviewer in mind,
let me know.

[stuartmorgan, 2012-04-26 08:06:13]

LGTM with nits. Good riddance!

You might want to put a TODO in WebDatabase::Init to make the LoginTable
creation Windows only at some point in the future?

https://chromiumcodereview.appspot.com/10227014/diff/7003/chrome/browser/pass...
File chrome/browser/password_manager/password_store_win.h (right):

https://chromiumcodereview.appspot.com/10227014/diff/7003/chrome/browser/pass...
chrome/browser/password_manager/password_store_win.h:28: // it there.
I'd eliminate the historical note, and just say "WebDataService is used for IE7
password fetching."

https://chromiumcodereview.appspot.com/10227014/diff/7003/chrome/browser/webd...
File chrome/browser/webdata/logins_table.cc (right):

https://chromiumcodereview.appspot.com/10227014/diff/7003/chrome/browser/webd...
chrome/browser/webdata/logins_table.cc:16: return false;
Remove this; there's no reason to fail init if we can't delete the table for
some reason.

https://chromiumcodereview.appspot.com/10227014/diff/7003/chrome/browser/webd...
File chrome/browser/webdata/web_data_service.h (right):

https://chromiumcodereview.appspot.com/10227014/diff/7003/chrome/browser/webd...
chrome/browser/webdata/web_data_service.h:437: // still using them for its
PasswordStore implementation.
Remove the NOTE, and change "Password manager" to something IE-specific.

[Mike Mammarella, 2012-04-26 18:07:33]

+thestig for owner powerz

https://chromiumcodereview.appspot.com/10227014/diff/7003/chrome/browser/pass...
File chrome/browser/password_manager/password_store_win.h (right):

https://chromiumcodereview.appspot.com/10227014/diff/7003/chrome/browser/pass...
chrome/browser/password_manager/password_store_win.h:28: // it there.
On 2012/04/26 08:06:13, stuartmorgan wrote:
> I'd eliminate the historical note, and just say "WebDataService is used for
IE7
> password fetching."

Done.

https://chromiumcodereview.appspot.com/10227014/diff/7003/chrome/browser/webd...
File chrome/browser/webdata/logins_table.cc (right):

https://chromiumcodereview.appspot.com/10227014/diff/7003/chrome/browser/webd...
chrome/browser/webdata/logins_table.cc:16: return false;
On 2012/04/26 08:06:13, stuartmorgan wrote:
> Remove this; there's no reason to fail init if we can't delete the table for
> some reason.

Done.

https://chromiumcodereview.appspot.com/10227014/diff/7003/chrome/browser/webd...
File chrome/browser/webdata/web_data_service.h (right):

https://chromiumcodereview.appspot.com/10227014/diff/7003/chrome/browser/webd...
chrome/browser/webdata/web_data_service.h:437: // still using them for its
PasswordStore implementation.
On 2012/04/26 08:06:13, stuartmorgan wrote:
> Remove the NOTE, and change "Password manager" to something IE-specific.

Done.

[Lei Zhang, 2012-04-26 19:44:49]

lgtm

https://chromiumcodereview.appspot.com/10227014/diff/4009/chrome/browser/pass...
File chrome/browser/password_manager/password_store_default.h (left):

https://chromiumcodereview.appspot.com/10227014/diff/4009/chrome/browser/pass...
chrome/browser/password_manager/password_store_default.h:11: #include
"base/memory/ref_counted.h"
I think you can remove this guy too?

https://chromiumcodereview.appspot.com/10227014/diff/4009/chrome/browser/webd...
File chrome/browser/webdata/web_database_migration_unittest.cc (right):

https://chromiumcodereview.appspot.com/10227014/diff/4009/chrome/browser/webd...
chrome/browser/webdata/web_database_migration_unittest.cc:229:
EXPECT_FALSE(connection.DoesTableExist("logins"));  // This one is obsolete.
You may want to put a short explanation here to explain what the table did.

[Mike Mammarella, 2012-04-26 20:58:18]

https://chromiumcodereview.appspot.com/10227014/diff/4009/chrome/browser/pass...
File chrome/browser/password_manager/password_store_default.h (left):

https://chromiumcodereview.appspot.com/10227014/diff/4009/chrome/browser/pass...
chrome/browser/password_manager/password_store_default.h:11: #include
"base/memory/ref_counted.h"
On 2012/04/26 19:44:49, Lei Zhang wrote:
> I think you can remove this guy too?

Done.

https://chromiumcodereview.appspot.com/10227014/diff/4009/chrome/browser/webd...
File chrome/browser/webdata/web_database_migration_unittest.cc (right):

https://chromiumcodereview.appspot.com/10227014/diff/4009/chrome/browser/webd...
chrome/browser/webdata/web_database_migration_unittest.cc:229:
EXPECT_FALSE(connection.DoesTableExist("logins"));  // This one is obsolete.
On 2012/04/26 19:44:49, Lei Zhang wrote:
> You may want to put a short explanation here to explain what the table did.

Done.