Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(872)

Issue 10226010: Fix SocketApiTest.SocketUDPExtension problem in some dbg bots. (Closed)

Created:
8 years, 8 months ago by Peng
Modified:
8 years, 8 months ago
Reviewers:
flackr, miket_OOO
CC:
chromium-reviews, Aaron Boodman, mihaip+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Fix SocketApiTest.SocketUDPExtension problem in some dbg bots. BUG=None TEST=browser_tests --gtest_filter=SocketApiTest.SocketTCPExtension Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133972

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/common/extensions/api/experimental.socket.idl View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
flackr
lgtm
8 years, 8 months ago (2012-04-25 20:19:22 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/penghuang@chromium.org/10226010/1
8 years, 8 months ago (2012-04-25 20:20:35 UTC) #2
commit-bot: I haz the power
Presubmit check for 10226010-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 8 months ago (2012-04-25 20:20:38 UTC) #3
Peng
Hi Mike, This CL is for fixing a broken in SocketApiTest.SocketUDPExtension on some dbg bots. ...
8 years, 8 months ago (2012-04-25 20:23:59 UTC) #4
miket_OOO
lgtm
8 years, 8 months ago (2012-04-25 20:29:50 UTC) #5
commit-bot: I haz the power
8 years, 8 months ago (2012-04-25 20:31:21 UTC) #6

Powered by Google App Engine
This is Rietveld 408576698