chrome/common/extensions/extension.cc - Issue 10224011: Add transparent support for filesystem URLs in URLPatterns.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/extension.cc

Issue 10224011: Add transparent support for filesystem URLs in URLPatterns. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Updated MatchesSecurityOrigin and added a comment, as discussed in IM. Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/extension.cc

diff --git a/chrome/common/extensions/extension.cc b/chrome/common/extensions/extension.cc

index 5d5045c95f7d2e78ad5ae829e5e89784aeb6b03c..90672d6dfd9d53c6dfbe46dbc09e6cce01e9e50d 100644

--- a/chrome/common/extensions/extension.cc

+++ b/chrome/common/extensions/extension.cc

@@ -2439,7 +2439,6 @@ FileBrowserHandler* Extension::LoadFileBrowserHandler(

// wildcards in URLPattern, so transform to what will match correctly.

filter.replace(0, 11, "chrome-extension://*/");

URLPattern pattern(URLPattern::SCHEME_EXTENSION);

- pattern.set_partial_filesystem_support_hack(true);

if (pattern.Parse(filter) != URLPattern::PARSE_SUCCESS) {

*error = ExtensionErrorUtils::FormatErrorMessageUTF16(

errors::kInvalidURLPatternError, filter);

« no previous file with comments | « no previous file | chrome/common/extensions/url_pattern.h » ('j') | no next file with comments »