Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10224007: Port XMLHttpRequest.response. (Closed)

Created:
8 years, 8 months ago by Anton Muhin
Modified:
8 years, 8 months ago
Reviewers:
podivilov
CC:
reviews+dom_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -2 lines) Patch
M Source/WebCore/bindings/dart/custom/DartXMLHttpRequestCustom.cpp View 1 2 1 chunk +64 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Anton Muhin
8 years, 8 months ago (2012-04-25 18:39:22 UTC) #1
podivilov
https://chromiumcodereview.appspot.com/10224007/diff/1/Source/WebCore/bindings/dart/custom/DartXMLHttpRequestCustom.cpp File Source/WebCore/bindings/dart/custom/DartXMLHttpRequestCustom.cpp (right): https://chromiumcodereview.appspot.com/10224007/diff/1/Source/WebCore/bindings/dart/custom/DartXMLHttpRequestCustom.cpp#newcode230 Source/WebCore/bindings/dart/custom/DartXMLHttpRequestCustom.cpp:230: responseTextGetter(args); What if responseTextGetter will throw an exception? Could ...
8 years, 8 months ago (2012-04-26 15:12:57 UTC) #2
Anton Muhin
https://chromiumcodereview.appspot.com/10224007/diff/1/Source/WebCore/bindings/dart/custom/DartXMLHttpRequestCustom.cpp File Source/WebCore/bindings/dart/custom/DartXMLHttpRequestCustom.cpp (right): https://chromiumcodereview.appspot.com/10224007/diff/1/Source/WebCore/bindings/dart/custom/DartXMLHttpRequestCustom.cpp#newcode230 Source/WebCore/bindings/dart/custom/DartXMLHttpRequestCustom.cpp:230: responseTextGetter(args); Thanks a lot for spotting, fixed. On 2012/04/26 ...
8 years, 8 months ago (2012-04-26 16:35:17 UTC) #3
podivilov
lgtm https://chromiumcodereview.appspot.com/10224007/diff/5001/Source/WebCore/bindings/dart/custom/DartXMLHttpRequestCustom.cpp File Source/WebCore/bindings/dart/custom/DartXMLHttpRequestCustom.cpp (right): https://chromiumcodereview.appspot.com/10224007/diff/5001/Source/WebCore/bindings/dart/custom/DartXMLHttpRequestCustom.cpp#newcode265 Source/WebCore/bindings/dart/custom/DartXMLHttpRequestCustom.cpp:265: #else Please replace #else with #endif.
8 years, 8 months ago (2012-04-26 18:02:54 UTC) #4
Anton Muhin
8 years, 8 months ago (2012-04-26 18:35:04 UTC) #5 
https://chromiumcodereview.appspot.com/10224007/diff/5001/Source/WebCore/bind...
File Source/WebCore/bindings/dart/custom/DartXMLHttpRequestCustom.cpp (right):

https://chromiumcodereview.appspot.com/10224007/diff/5001/Source/WebCore/bind...
Source/WebCore/bindings/dart/custom/DartXMLHttpRequestCustom.cpp:265: #else
On 2012/04/26 18:02:54, podivilov wrote:
> Please replace #else with #endif.

Done.

Powered by Google App Engine
This is Rietveld 408576698