lib/compiler/implementation/namer.dart - Issue 10223002: Use JsNames.getValid instead of implementing another (broken) version of it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/compiler/implementation/namer.dart

Issue 10223002: Use JsNames.getValid instead of implementing another (broken) version of it. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: lib/compiler/implementation/namer.dart

diff --git a/lib/compiler/implementation/namer.dart b/lib/compiler/implementation/namer.dart

index 8680ac740b738f368376602dd1b798281d124059..b01114b6fac44823e4ed481a135d670dd9636bbf 100644

--- a/lib/compiler/implementation/namer.dart

+++ b/lib/compiler/implementation/namer.dart

@@ -64,10 +64,7 @@ class Namer {

String instanceFieldName(LibraryElement lib, SourceString name) {

String proposedName = privateName(lib, name);

- if (jsReserved.contains(proposedName)) {

- return '$proposedName\$';

- }

- return proposedName;

+ return JsNames.getValid(proposedName);

}

String setterName(LibraryElement lib, SourceString name) {

« no previous file with comments | « no previous file | no next file » | no next file with comments »