Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Unified Diff: presubmit_canned_checks.py

Issue 10222020: Output a list of suggested OWNERS reviewers when needed. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Ready for commit Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « owners.py ('k') | tests/owners_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: presubmit_canned_checks.py
diff --git a/presubmit_canned_checks.py b/presubmit_canned_checks.py
index e7b503e0af5cdd4007ba14cde0eef095d30ef78d..013effdc5deb97dccd5b63a8fdddc5cd2f46b8c2 100644
--- a/presubmit_canned_checks.py
+++ b/presubmit_canned_checks.py
@@ -769,8 +769,14 @@ def CheckOwners(input_api, output_api, source_file_filter=None):
missing_directories = owners_db.directories_not_covered_by(affected_files,
reviewers_plus_owner)
if missing_directories:
- return [output('Missing %s for files in these directories:\n %s%s' %
- (needed, '\n '.join(missing_directories), message))]
+ output_list = [
+ output('Missing %s for files in these directories:\n %s%s' %
+ (needed, '\n '.join(missing_directories), message))]
+ if not input_api.is_committing:
+ suggested_owners = owners_db.reviewers_for(affected_files)
+ output_list.append(output('Suggested OWNERS:\n %s' %
+ ('\n '.join(suggested_owners))))
+ return output_list
if input_api.is_committing and not reviewers:
return [output('Missing LGTM from someone other than %s' % owner_email)]
« no previous file with comments | « owners.py ('k') | tests/owners_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698