chrome/renderer/autofill/password_generation_manager_browsertest.cc - Issue 10222017: Make password generation switched by a preference in chrome settings rather than a command line fla…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/autofill/password_generation_manager_browsertest.cc

Issue 10222017: Make password generation switched by a preference in chrome settings rather than a command line fla… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Make MockAutofillManager to use the constructor designated for unit tests to avoid dangling pref_ob… Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/autofill/autofill_external_delegate_unittest.cc ('K') | « chrome/renderer/autofill/password_generation_manager.cc ('k') | chrome/renderer/chrome_content_renderer_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/autofill/password_generation_manager_browsertest.cc

diff --git a/chrome/renderer/autofill/password_generation_manager_browsertest.cc b/chrome/renderer/autofill/password_generation_manager_browsertest.cc

index 69074b0dba50de96fd6665542a32854be707dfdc..12a5158579ead9ba8855e5973624087dc29d7455 100644

--- a/chrome/renderer/autofill/password_generation_manager_browsertest.cc

+++ b/chrome/renderer/autofill/password_generation_manager_browsertest.cc

@@ -112,7 +112,7 @@ TEST_F(PasswordGenerationManagerTest, DetectionTest) {

SetFocused(first_password_element.to<WebNode>());

EXPECT_EQ(0u, generation_manager_->messages().size());

- // Pretend like sync was enabled.

+ // Pretend like password generation was enabled.

AutofillMsg_PasswordGenerationEnabled msg(0, true);

generation_manager_->OnMessageReceived(msg);