Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Unified Diff: chrome/renderer/chrome_content_renderer_client.cc

Issue 10222017: Make password generation switched by a preference in chrome settings rather than a command line fla… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Change DCHECK_EQ to DCHECK to get around some type convertion issue. Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/autofill/password_generation_manager_browsertest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/chrome_content_renderer_client.cc
diff --git a/chrome/renderer/chrome_content_renderer_client.cc b/chrome/renderer/chrome_content_renderer_client.cc
index e380f31246295319eefdaaa9928e53025356236c..4013b92f023815da21689200c4142b13caba1e3d 100644
--- a/chrome/renderer/chrome_content_renderer_client.cc
+++ b/chrome/renderer/chrome_content_renderer_client.cc
@@ -255,6 +255,10 @@ void ChromeContentRendererClient::RenderViewCreated(
new PasswordAutofillManager(render_view);
AutofillAgent* autofill_agent = new AutofillAgent(render_view,
password_autofill_manager);
+ if (CommandLine::ForCurrentProcess()->HasSwitch(
+ switches::kEnablePasswordGeneration)) {
+ new PasswordGenerationManager(render_view);
+ }
PageClickTracker* page_click_tracker = new PageClickTracker(render_view);
// Note that the order of insertion of the listeners is important.
// The password_autocomplete_manager takes the first shot at processing the
@@ -272,10 +276,6 @@ void ChromeContentRendererClient::RenderViewCreated(
switches::kDomAutomationController)) {
new AutomationRendererHelper(render_view);
}
- if (CommandLine::ForCurrentProcess()->HasSwitch(
- switches::kEnablePasswordGeneration)) {
- new PasswordGenerationManager(render_view);
- }
}
void ChromeContentRendererClient::SetNumberOfViews(int number_of_views) {
« no previous file with comments | « chrome/renderer/autofill/password_generation_manager_browsertest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698