Make password generation switched by a preference in chrome settings rather than a command line fla…

chrome/renderer/autofill/password_generation_manager.cc

Index: chrome/renderer/autofill/password_generation_manager.cc
diff --git a/chrome/renderer/autofill/password_generation_manager.cc b/chrome/renderer/autofill/password_generation_manager.cc
index 687c035e26579f2a98973b1e5195ebd12bdad4ab..097daaa8aa6b7dcfd89a8369fca344ecdbd239ca 100644
--- a/chrome/renderer/autofill/password_generation_manager.cc
+++ b/chrome/renderer/autofill/password_generation_manager.cc
@@ -24,8 +24,7 @@ PasswordGenerationManager::PasswordGenerationManager(
 PasswordGenerationManager::~PasswordGenerationManager() {}
 
 void PasswordGenerationManager::DidFinishDocumentLoad(WebKit::WebFrame* frame) {
-  // We don't want to generate passwords if the browser won't store or sync
-  // them.
+  // We don't want to generate passwords if browser doesn't think so.

[Ilya Sherman, 2012/05/01 22:27:48]

nit: Please preserve the previous comment, or else remove this entirely.  The
existing comment adds no information beyond the code itself.

[zysxqn, 2012/05/03 00:57:24]

Done.

   if (!enabled_)
     return;
 
@@ -91,7 +90,7 @@ bool PasswordGenerationManager::OnMessageReceived(const IPC::Message& message) {
     IPC_MESSAGE_HANDLER(AutofillMsg_GeneratedPasswordAccepted,
                         OnPasswordAccepted)
     IPC_MESSAGE_HANDLER(AutofillMsg_PasswordGenerationEnabled,
-                        OnPasswordSyncEnabled)
+                        OnPasswordGenerationEnabled)

[Ilya Sherman, 2012/05/01 22:27:48]

Good catch, thanks for fixing this :)

     IPC_MESSAGE_UNHANDLED(handled = false)
   IPC_END_MESSAGE_MAP()
   return handled;
@@ -106,7 +105,7 @@ void PasswordGenerationManager::OnPasswordAccepted(const string16& password) {
   }
 }
 
-void PasswordGenerationManager::OnPasswordSyncEnabled(bool enabled) {
+void PasswordGenerationManager::OnPasswordGenerationEnabled(bool enabled) {
   enabled_ = enabled;
 }