Make password generation switched by a preference in chrome settings rather than a command line fla…

chrome/browser/resources/options2/browser_options.js

Index: chrome/browser/resources/options2/browser_options.js
diff --git a/chrome/browser/resources/options2/browser_options.js b/chrome/browser/resources/options2/browser_options.js
index 96b856e7466017931d7bd1fa6575046858e0dbde..697d8fc8ed57ed12fa96318d85a8346900a91b68 100644
--- a/chrome/browser/resources/options2/browser_options.js
+++ b/chrome/browser/resources/options2/browser_options.js
@@ -1041,6 +1041,19 @@ cr.define('options', function() {
     },
 
     /**
+     * @private

[Ilya Sherman, 2012/05/01 22:27:48]

nit: Please include a comment describing the purpose/use of this function.

[zysxqn, 2012/05/03 00:57:24]

Done.

+     */
+    setPasswordGenerationSettingVisibility_: function(visible) {
+      if (visible) {
+        $('passwordGenerationEnabled').style.display = 'block';
+        $('passwordGenerationEnabledDesc').style.display = 'block';
+      } else {
+        $('passwordGenerationEnabled').style.display = 'none';
+        $('passwordGenerationEnabledDesc').style.display = 'none';
+      }

[Ilya Sherman, 2012/05/01 22:27:48]

nit: Why not set the visibility of the containing <div> element, rather than
setting the visibility individually for the child elements?

[zysxqn, 2012/05/03 00:57:24]

Done.

+    },
+
+    /**
      * Set the font size selected item.
      * @private
      */
@@ -1370,6 +1383,7 @@ cr.define('options', function() {
     'setInstantFieldTrialStatus',
     'setMetricsReportingCheckboxState',
     'setMetricsReportingSettingVisibility',
+    'setPasswordGenerationSettingVisibility',
     'setProfilesInfo',
     'setScreenMagnifierCheckboxState',
     'setSpokenFeedbackCheckboxState',