Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(734)

Issue 10222011: Adding Windows service template for Cloud Print connector. (Closed)

Created:
8 years, 8 months ago by gene
Modified:
8 years, 8 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Adding Windows service template for Cloud Print connector. Current Service can register and unrerister itself as a Windows Service. This service is not part of the Chrome browser, but belongs to the place as virtual print driver for cloud print. BUG=125026 TEST=Build and verify service gets registered with "/Service" command. And unregistered with "/UninstallService" command. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=134298

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -1 line) Patch
M build/all.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M cloud_print/OWNERS View 1 chunk +3 lines, -1 line 0 comments Download
A cloud_print/service/win/cloud_print_service.h View 1 1 chunk +27 lines, -0 lines 0 comments Download
A cloud_print/service/win/cloud_print_service.cc View 1 2 1 chunk +41 lines, -0 lines 0 comments Download
A cloud_print/service/win/cloud_print_service.rc View 1 2 3 4 5 6 Binary file 0 comments Download
A cloud_print/service/win/cloud_print_service.rgs View 1 chunk +3 lines, -0 lines 0 comments Download
A cloud_print/service/win/resource.h View 1 1 chunk +17 lines, -0 lines 0 comments Download
A cloud_print/service/win/service.gyp View 1 chunk +30 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
gene
8 years, 8 months ago (2012-04-25 18:28:58 UTC) #1
Vitaly Buka (NO REVIEWS)
lgtm On 2012/04/25 18:28:58, gene wrote:
8 years, 8 months ago (2012-04-25 18:46:15 UTC) #2
Albert Bodenhamer
I know this is just a shell, but are there any tests it makes sense ...
8 years, 8 months ago (2012-04-25 19:07:35 UTC) #3
gene
I would love to add tests here. But I can't think of any useful tests ...
8 years, 8 months ago (2012-04-25 20:10:27 UTC) #4
Albert Bodenhamer
lgtm On Wed, Apr 25, 2012 at 1:10 PM, <gene@chromium.org> wrote: > I would love ...
8 years, 8 months ago (2012-04-25 21:02:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gene@chromium.org/10222011/9001
8 years, 8 months ago (2012-04-25 21:08:14 UTC) #6
commit-bot: I haz the power
Failed to request the patch to try. Please note that binary filesare still unsupported at ...
8 years, 8 months ago (2012-04-25 21:08:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gene@chromium.org/10222011/11004
8 years, 8 months ago (2012-04-25 22:27:26 UTC) #8
commit-bot: I haz the power
8 years, 8 months ago (2012-04-25 22:27:31 UTC) #9
Failed to request the patch to try. Please note that binary filesare still
unsupported at the moment, this is being worked on.

Thanks for your patience.

HTTP Error 302: Found

Powered by Google App Engine
This is Rietveld 408576698