Protect all uses of JSON.parse against exceptions.

remoting/webapp/host_controller.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 /** @suppress {duplicate} */
 var remoting = remoting || {};
 
 /** @constructor */
@@ skipping 226 matching lines @@
 };
 
 /**
  * Parse a stringified host configuration and return it as a dictionary if it
  * is well-formed and contains both host_id and xmpp_login keys.  null is
  * returned if either key is missing, or if the configuration is corrupt.
  * @param {string} configStr The host configuration, JSON encoded to a string.
  * @return {Object.<string,string>|null} The host configuration.
  */
 function parseHostConfig_(configStr) {
-  try {
-    var config = /** @type {Object.<string,string>} */ JSON.parse(configStr);
-    if (typeof config['host_id'] == 'string' &&
-        typeof config['xmpp_login'] == 'string') {
-      return config;
-    }
-  } catch (err) {
+  var config = /** @type {Object.<string,string>} */ jsonParseSafe(configStr);
+  if (config &&
+      typeof config['host_id'] == 'string' &&
+      typeof config['xmpp_login'] == 'string') {
+    return config;
+  } else {
+    console.error('Invalid getDaemonConfig response.');
   }
   return null;
 }
 
 /**
  * @param {string} newPin The new PIN to set
  * @param {function(remoting.HostController.AsyncResult):void} callback
  *     Callback to be called when finished.
  * @return {void} Nothing.
  */
@@ skipping 84 matching lines @@
   try {
     this.plugin_.getDaemonConfig(onConfig);
   } catch (err) {
     this.setHost(null);
     onDone();
   }
 };
 
 /** @type {remoting.HostController} */
 remoting.hostController = null;