Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 10221020: Update ninja to 9b8e55d (Closed)

Created:
8 years, 8 months ago by Nico
Modified:
8 years, 8 months ago
Reviewers:
scottmg
CC:
chromium-reviews, Dirk Pranke
Visibility:
Public.

Description

Update ninja to 9b8e55d On Linux, I did a full ninja checkout and then ran: python bootstrap.py ./configure.py --with-gtest=../chrome/src/testing/gtest ./ninja ninja_test ./ninja_test # (all tests passed) strip ninja I timed empty builds of 'chrome' with the old and the new version, both took 1.1s for that. Binary size comparison: 121632 bytes old binary 129920 bytes new binary I used gcc 4.4.3 to build ninja. On Mac, I updated an existing checkout to the latest version and then ran: CXX=../chrome-git/src/third_party/llvm-build/Release+Asserts/bin/clang++ \ ./configure.py -with-gtest=../chrome-git/src/testing/gtest ./ninja ./ninja ninja_test # (all tests passed) strip ninja I timed empty builds of 'chrome' with the old and the new version, both took 1.1s for that. Binary size comparison: 128976 bytes old binary 120904 bytes new binary I used clang r155352 to build ninja. Last time I used gcc 4.2, which explains the size drop. The major new features in this update are: * ninja cleans up files when interrupted mid-build * NINJA_STATUS environment variable to tweak the status line (see ninja manual) Also set svn:mime-type to application/octet-stream on these two files. r134307

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1023 lines, -847 lines) Patch
M ninja-linux64 View 5 chunks +317 lines, -239 lines 0 comments Download
M ninja-mac View 4 chunks +706 lines, -608 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Nico
8 years, 8 months ago (2012-04-27 18:16:59 UTC) #1
scottmg
lgtm
8 years, 8 months ago (2012-04-27 18:18:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/10221020/1
8 years, 8 months ago (2012-04-27 18:20:33 UTC) #3
commit-bot: I haz the power
Can't apply patch for file depot_tools/ninja-linux64. While running patch -p0 --forward --force; patching file depot_tools/ninja-linux64 ...
8 years, 8 months ago (2012-04-27 18:20:35 UTC) #4
scottmg
It doesn't work for binaries or > ~100k; have to gcl commit afaik.
8 years, 8 months ago (2012-04-27 18:22:30 UTC) #5
M-A Ruel
On 2012/04/27 18:22:30, scottmg wrote: > It doesn't work for binaries or > ~100k; have ...
8 years, 8 months ago (2012-04-27 18:32:51 UTC) #6
M-A Ruel
On 2012/04/27 18:32:51, Marc-Antoine Ruel wrote: > On 2012/04/27 18:22:30, scottmg wrote: > > It ...
8 years, 8 months ago (2012-04-27 18:32:58 UTC) #7
Nico
8 years, 8 months ago (2012-04-27 23:21:25 UTC) #8
On 2012/04/27 18:32:51, Marc-Antoine Ruel wrote:
> On 2012/04/27 18:22:30, scottmg wrote:
> > It doesn't work for binaries or > ~100k; have to gcl commit afaik.
> 
> For binary files, just commit them right awat.

I know. I had created this CL in a binary checkout, so I clicked 'cq' even
though I knew better, hoping I wouldn't have to patch it in to a different
directory instead.

Powered by Google App Engine
This is Rietveld 408576698