net/third_party/nss/patches/falsestartnpn2.patch - Issue 10221018: net: don't set NSS options in a callback.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: net/third_party/nss/patches/falsestartnpn2.patch

Issue 10221018: net: don't set NSS options in a callback. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: ... Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 diff --git a/net/third_party/nss/ssl/ssl3con.c b/net/third_party/nss/ssl/ssl3con .c

	2 index 5476fa5..1465558 100644

	3 --- a/net/third_party/nss/ssl/ssl3con.c

	4 +++ b/net/third_party/nss/ssl/ssl3con.c

	5 @@ -6108,6 +6108,10 @@ ssl3_CanFalseStart(sslSocket *ss) {

	6 rv = ss->opt.enableFalseStart &&

	7 !ss->sec.isServer &&

	8 !ss->ssl3.hs.isResuming &&

	9 + /* This check for NPN is performed here because we can't call

	10 + * SSL_HandshakeNegotiatedExtension in the auth callback because of

	11 + * lock ordering issues. See crbug.com/125299 */

	12 + ssl3_ExtensionNegotiated(ss, ssl_next_proto_nego_xtn) &&

	13 ss->ssl3.cwSpec &&

	14

	15 /* An attacker can control the selected ciphersuite so we only wish to

OLD	NEW

« no previous file with comments | « net/third_party/nss/patches/applypatches.sh ('k') | net/third_party/nss/ssl/ssl3con.c » ('j') | no next file with comments »