Issue 10219009: Convert CalculateMinString() to string16.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10219009: Convert CalculateMinString() to string16. (Closed)

Created:
8 years, 8 months ago by tfarina

Modified:
8 years, 8 months ago

Reviewers:
Peter Kasting

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Convert CalculateMinString() to string16. BUG=23581 R=pkasting@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133956

Patch Set 1 #

Total comments: 1

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -24 lines)			Patch
M	chrome/browser/ui/cocoa/location_bar/selected_keyword_decoration.mm	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/gtk/location_bar_view_gtk.cc	View	1 chunk	+4 lines, -7 lines	0 comments	Download
M	chrome/browser/ui/omnibox/location_bar_util.h	View	3 chunks	+4 lines, -2 lines	1 comment	Download
M	chrome/browser/ui/omnibox/location_bar_util.cc	View	2 chunks	+7 lines, -7 lines	0 comments	Download
M	chrome/browser/ui/views/location_bar/selected_keyword_view.cc	View	2 chunks	+3 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Peter Kasting

8 years, 8 months ago (2012-04-25 18:23:57 UTC) #2

LGTM

http://codereview.chromium.org/10219009/diff/1/chrome/browser/ui/omnibox/loca...
File chrome/browser/ui/omnibox/location_bar_util.h (right):

http://codereview.chromium.org/10219009/diff/1/chrome/browser/ui/omnibox/loca...
chrome/browser/ui/omnibox/location_bar_util.h:18: std::wstring
GetKeywordName(Profile* profile, const std::wstring& keyword);
Nit: Can we change this function too, so we can eliminate the <string> include?

Expand Messages | Collapse Messages