net: don't remember TLS intolerant servers.

net/test/base_test_server.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_TEST_BASE_TEST_SERVER_H_
 #define NET_TEST_BASE_TEST_SERVER_H_
 #pragma once
 
 #include <string>
 #include <utility>
@@ skipping 108 matching lines @@
 
     // A bitwise-OR of BulkCipher that should be used by the
     // HTTPS server, or BULK_CIPHER_ANY to indicate that all implemented
     // ciphers are acceptable.
     int bulk_ciphers;
 
     // If true, pass the --https-record-resume argument to testserver.py which
     // causes it to log session cache actions and echo the log on
     // /ssl-session-cache.
     bool record_resume;
+
+    // If true, the server will abruptly close any TLS connections in order to
+    // test SSLv3 fallback.

[wtc, 2012/04/26 00:49:14]

COMMENT BUG: I was confused by this comment because I thought
by "abrutly closing a TLS connection" you meant closing the
underlying TCP connection, which is one behavior of TLS-intolerant
servers.

How about "the server will abort a TLS handshake with a handshake_failure alert"
or just "the server will abort any TLS handshakes"?

Please make the same change to the comments in the Python files.

[agl, 2012/04/26 17:03:29]

Done.

+    bool tls_intolerant;
   };
 
   // Pass as the 'host' parameter during construction to server on 127.0.0.1
   static const char kLocalhost[];
 
   // The auth token to be used for TYPE_GDATA server.
   static const char kGDataAuthToken[];
 
   // Initialize a TestServer listening on a specific host (IP or hostname).
   BaseTestServer(Type type,  const std::string& host);
@@ skipping 85 matching lines @@
 
   scoped_ptr<ScopedPortException> allowed_port_;
 
   DISALLOW_COPY_AND_ASSIGN(BaseTestServer);
 };
 
 }  // namespace net
 
 #endif  // NET_TEST_BASE_TEST_SERVER_H_